gh-79856: IDLE - separate config_key window and frame #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
changed the title
|
When you're done making the requested changes, leave the comment: |
iritkatriel
added
the
pending
terryjreedy
changed the title
terryjreedy
removed
awaiting changes
pending
terryjreedy
changed the title
|
Thanks @csabella for the PR, and @terryjreedy for merging it |
|
GH-97683 is a backport of this pull request to the 3.11 branch. |
|
GH-97684 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
terryjreedy
changed the title
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 2, 2022
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Split dialog class into a Window class and Frame class and adjust tests to match.