Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39050: The Help button in IDLE's config menu does not work #17611

Merged
merged 9 commits into from Jan 23, 2020
Merged

bpo-39050: The Help button in IDLE's config menu does not work #17611

merged 9 commits into from Jan 23, 2020
+15 −1

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Dec 14, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39050
@ZackerySpytz
bpo-39050: The Help button in IDLE's config menu does not work
Loading status checks…
5e5c5b7
@ZackerySpytz ZackerySpytz requested a review from terryjreedy as a code owner Dec 14, 2019
@ZackerySpytz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ZackerySpytz commented Dec 14, 2019

The text param of view_text() was renamed to contents in 3221a63.

I don't think this fix needs a news entry.
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Dec 18, 2019

This gets a news entry, so people know that they can use the button again. I will add one if still needed when merging.
@csabella
csabella reviewed Jan 19, 2020
View changes
Lib/idlelib/configdialog.py Outdated Show resolved Hide resolved
@ZackerySpytz
Merge remote-tracking branch 'upstream/master' into bpo-39050-idle-he…
9d39349 
…lp-button-config
@ZackerySpytz
Remove spaces.
Loading status checks…
c2378d1
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor

csabella commented Jan 21, 2020

Thanks, @ZackerySpytz. Please also add the News Entry that Terry requested.
terryjreedy added 6 commits Jan 23, 2020
@terryjreedy
Add help button test.
78f3ece
@terryjreedy
blurb
9c28dde
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_17611
472d060
@terryjreedy
NEWS.txt item.
Loading status checks…
4f29d01
@terryjreedy
Update 2020-01-22-22-28-06.bpo-39050.zkn0FO.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5f5ff4
@terryjreedy
Update NEWS.txt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
66562bd
@terryjreedy
terryjreedy approved these changes Jan 23, 2020
View changes
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 23, 2020

I added a test that would have failed and caught the regression. This was part of the 6% still not covered. Zack, thanks for reporting and finding the reason.
@terryjreedy terryjreedy merged commit 2e43b64 into python:master Jan 23, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200123.16 succeeded
Details
bedevere/issue-number Issue number 39050 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

Sorry @ZackerySpytz and @terryjreedy, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2e43b64c94e49f7133b9c26e84c9519935c49063 3.8
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@ZackerySpytz @miss-islington
bpo-39050: The Help button in IDLE's config menu works again (pythonG…
b0e03e9 
…H-17611)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 23, 2020

GH-18136 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@ZackerySpytz @miss-islington
bpo-39050: The Help button in IDLE's config menu works again (pythonG…
fc4f20a 
…H-17611)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 23, 2020

GH-18137 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @ZackerySpytz
bpo-39050: The Help button in IDLE's config menu works again (GH-17611)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba83d1e 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @ZackerySpytz
bpo-39050: The Help button in IDLE's config menu works again (GH-17611)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3b76188 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@ZackerySpytz @terryjreedy @csabella @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.