Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context manager over try-finally #18176

Open
wants to merge 1 commit into
base: master
from
Open

Use context manager over try-finally #18176

wants to merge 1 commit into from
+1 −4

Conversation

@alanyee
Copy link
Contributor

alanyee commented Jan 25, 2020

-Use context manager over try-finally
-Use format() over % as intended by PEP 3101
@alanyee
Update archive_util.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7cafb7d 
-Use context manager over try-finally
-Use format() over % under PEP 3101
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Member

tirkarthi commented Jan 25, 2020

This looks similar to work done at #10921 . cc: @serhiy-storchaka @merwok

I am not sure about the % format change.
@merwok

This comment has been minimized.

Sign in to view
Copy link
Contributor

merwok commented Jan 26, 2020

I’m afraid this is a cosmetic change that does not fix a bug or improve maintainability, so generally not done for the Python project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
5 participants
@alanyee @tirkarthi @merwok @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.