bpo-37415: Fix stdatomic.h header check for ICC compiler #16717

vstinner · 2019-10-11T13:37:50Z

Fix stdatomic.h header check for ICC compiler: the ICC implementation
lacks atomic_uintptr_t type which is needed by Python.

https://bugs.python.org/issue37415

vstinner · 2019-10-11T13:42:11Z

I removed ATOMIC_VAR_INIT() check from configure, since it's not used in Python.


        bpo-37415: Fix stdatomic.h header check for ICC compiler

Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python.

adamjstewart · 2019-10-21T00:41:48Z

This should also fix https://bugs.python.org/issue35473

vstinner · 2019-10-21T10:06:58Z

@adamjstewart: Can you test this PR with ICC?

adamjstewart · 2019-10-21T15:52:12Z

I'm still working on getting access to our cluster, but once I have access I can definitely test this PR!

adamjstewart · 2019-10-21T21:26:38Z

I assume the runstatedir portions of the patch aren't actually needed to fix the intel build?

vstinner · 2019-10-21T21:57:30Z

I assume the runstatedir portions of the patch aren't actually needed to fix the intel build?

I'm running "autoconf". Depending who run "autoconf" to generate the latest configure in script and depending on my autoconf version, the runstatedir thing may or may not change. I never understood how to get a reliable output using autotools.

adamjstewart · 2019-10-22T03:54:51Z

This patch seems to be working so far. I tried running the unit tests and only saw a few failures:

Ran 327 tests in 205.461s

OK (skipped=30)
4 tests failed again:
    test_asyncio test_distutils test_gdb test_imaplib

== Tests result: FAILURE then FAILURE ==

399 tests OK.

4 tests failed:
    test_asyncio test_distutils test_gdb test_imaplib

13 tests skipped:
    test_curses test_devpoll test_kqueue test_msilib test_ossaudiodev
    test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
    test_winreg test_winsound test_zipfile64

7 re-run tests:
    test_asyncio test_distutils test_gdb test_imaplib
    test_multiprocessing_fork test_multiprocessing_forkserver
    test_multiprocessing_spawn

Total duration: 20 min 47 sec
Tests result: FAILURE then FAILURE
make: *** [test] Error 2

I'm going to try to install anyway.

adamjstewart · 2019-10-22T05:39:13Z

The install succeeded! With the minimal patch found here, I was able to build Python 3.7.4 with Intel 18.0.3.222 on Cray CNL5. The patch successfully applies to Python 3.6.7-3.6.8, 3.7.1-3.7.4, and 3.8.0 release tarballs. We may want to backport this to Python 3.6 if it's still supported. I believe this bug was likely introduced in Python 3.6.7, 3.7.1, and 3.8.0. Thanks for your help @vstinner!

vstinner · 2019-10-22T19:53:27Z

4 tests failed: test_asyncio test_distutils test_gdb test_imaplib

That's unrelated to https://bugs.python.org/issue37415

https://bugs.python.org/issue37415 is only about a compilation failure when using ICC.

miss-islington · 2019-10-22T19:53:53Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2019-10-22T19:53:53Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

bedevere-bot · 2019-10-22T19:54:05Z

GH-16892 is a backport of this pull request to the 3.7 branch.


        bpo-37415: Fix stdatomic.h header check for ICC compiler (pythonGH-16717

) Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python. (cherry picked from commit 028f734) Co-authored-by: Victor Stinner <vstinner@python.org>

miss-islington · 2019-10-22T19:54:30Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖


        bpo-37415: Fix stdatomic.h header check for ICC compiler (pythonGH-16717

) Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python. (cherry picked from commit 028f734) Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-bot · 2019-10-22T19:54:39Z

GH-16893 is a backport of this pull request to the 3.8 branch.


        bpo-37415: Fix stdatomic.h header check for ICC compiler (GH-16717)

Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python. (cherry picked from commit 028f734) Co-authored-by: Victor Stinner <vstinner@python.org>


        bpo-37415: Fix stdatomic.h header check for ICC compiler (GH-16717)

Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python. (cherry picked from commit 028f734) Co-authored-by: Victor Stinner <vstinner@python.org>


        bpo-37415: Fix stdatomic.h header check for ICC compiler (pythonGH-16717

) Fix stdatomic.h header check for ICC compiler: the ICC implementation lacks atomic_uintptr_t type which is needed by Python. Test: * atomic_int and atomic_uintptr_t types * atomic_load_explicit() and atomic_store_explicit() * memory_order_relaxed and memory_order_seq_cst constants But don't test ATOMIC_VAR_INIT(): it's not used in Python.

vstinner added the needs backport to 3.8 label Oct 11, 2019

the-knights-who-say-ni added the CLA signed label Oct 11, 2019

bedevere-bot added the awaiting core review label Oct 11, 2019

vstinner added the needs backport to 3.7 label Oct 11, 2019

vstinner force-pushed the vstinner:icc_atomic branch from 9f73d25 to a12eefb Oct 11, 2019

vstinner force-pushed the vstinner:icc_atomic branch from a12eefb to 87ed388 Oct 11, 2019

adamjstewart mentioned this pull request Oct 21, 2019

Default to Python 3.7 #10319

Merged

vstinner deleted the vstinner:icc_atomic branch Oct 22, 2019

bedevere-bot removed the awaiting core review label Oct 22, 2019

bedevere-bot removed the needs backport to 3.7 label Oct 22, 2019

vstinner added needs backport to 3.8 and removed needs backport to 3.8 labels Oct 22, 2019

bedevere-bot removed the needs backport to 3.8 label Oct 22, 2019

python / cpython

bpo-37415: Fix stdatomic.h header check for ICC compiler #16717

bpo-37415: Fix stdatomic.h header check for ICC compiler #16717

vstinner commented Oct 11, 2019 •

edited by bedevere-bot

This comment has been minimized.

vstinner commented Oct 11, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

vstinner commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

vstinner commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 22, 2019

This comment has been minimized.

adamjstewart commented Oct 22, 2019

This comment has been minimized.

vstinner commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

bedevere-bot commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

bedevere-bot commented Oct 22, 2019

python / cpython

Sponsor python/cpython

Join GitHub today

bpo-37415: Fix stdatomic.h header check for ICC compiler #16717

bpo-37415: Fix stdatomic.h header check for ICC compiler #16717

Conversation

vstinner commented Oct 11, 2019 • edited by bedevere-bot

This comment has been minimized.

vstinner commented Oct 11, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

vstinner commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 21, 2019

This comment has been minimized.

vstinner commented Oct 21, 2019

This comment has been minimized.

adamjstewart commented Oct 22, 2019

This comment has been minimized.

adamjstewart commented Oct 22, 2019

This comment has been minimized.

vstinner commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

bedevere-bot commented Oct 22, 2019

This comment has been minimized.

miss-islington commented Oct 22, 2019

This comment has been minimized.

bedevere-bot commented Oct 22, 2019

vstinner commented Oct 11, 2019 •

edited by bedevere-bot