Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39324: Add markdown mimetype mapping #17995

Open
wants to merge 2 commits into
base: master
from

Conversation

@rdbatch02
Copy link

rdbatch02 commented Jan 13, 2020

Adding markdown mapping (.md <-> text/markdown) to mimetypes as registered here https://www.iana.org/assignments/media-types/text/markdown.

https://bugs.python.org/issue39324

@rdbatch02 rdbatch02 requested a review from python/email-team as a code owner Jan 13, 2020
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 13, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rdbatch02

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

eamanu left a comment

Hi, @rdbatch02 thanks for the PR. IMHO this should be discuss, I recommend you write to python-ideas mailing list, but the opened the issue it's ok.

This will need a NEWS. And don't forget sign the CLA

@rdbatch02

This comment has been minimized.

Copy link
Author

rdbatch02 commented Jan 14, 2020

Hi, @rdbatch02 thanks for the PR. IMHO this should be discuss, I recommend you write to python-ideas mailing list, but the opened the issue it's ok.

This will need a NEWS. And don't forget sign the CLA

Hi @eamanu, I've added a NEWS and it looks like the CLA went through. Should I plan to submit this to the mailing list as well in addition to the issue that I opened? Or can discussion be solicited on the open issue?

@tirkarthi

This comment has been minimized.

Copy link
Member

tirkarthi commented Jan 18, 2020

The RFC also includes .markdown as an extension though I have seen .md to be more common

Relevant part : "File extension(s): .md, .markdown"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.