Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38453: Ensure correct short path is obtained for test #17184

Merged
merged 1 commit into from Nov 16, 2019
Merged

bpo-38453: Ensure correct short path is obtained for test #17184

merged 1 commit into from Nov 16, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Nov 15, 2019 •
edited by bedevere-bot

@zooba zooba added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir OS-windows needs backport to 3.8 labels Nov 15, 2019
@zooba
Copy link
Member Author

zooba commented Nov 16, 2019

I also ran this on the buildbots and it was fine.

@zooba zooba merged commit 7c6130c into python:master Nov 16, 2019
@zooba zooba deleted the bpo-38453 branch Nov 16, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7c6130c8c36c941255365e5414c956fc919b8629 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2019

GH-17186 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 16, 2019
@miss-islington @zooba
bpo-38453: Ensure correct short path is obtained for test (GH-17184)
6f602fb 
(cherry picked from commit 7c6130c)

Co-authored-by: Steve Dower <steve.dower@python.org>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@zooba
bpo-38453: Ensure correct short path is obtained for test (pythonGH-1…
4dae819 
…7184)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@zooba @shihai1991
bpo-38453: Ensure correct short path is obtained for test (pythonGH-1…
be45ab7 
…7184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
OS-windows skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni