Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38897: Remove use of deprecated `array.fromstring` method #17332

Merged
merged 1 commit into from Nov 26, 2019
Merged

bpo-38897: Remove use of deprecated `array.fromstring` method #17332

merged 1 commit into from Nov 26, 2019
+3 −3

Conversation

@dcoles
Copy link
Contributor

dcoles commented Nov 22, 2019 •
edited by bedevere-bot

Using array.fromstring generates a DeprecationWarning on current versions of Python.

https://bugs.python.org/issue38897
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Nov 22, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@dcoles

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member

corona10 commented Nov 22, 2019

@dcoles Thanks for the contribution.
Before processing the code review, Would you like to create an issue for this PR on bugs.python.org?

Thank you :)
@dcoles dcoles changed the title Remove use of deprecated `array.fromstring` method bpo-38897: Remove use of deprecated `array.fromstring` method Nov 22, 2019
@dcoles dcoles force-pushed the dcoles:patch-1 branch from 4556383 to bfe504b Nov 22, 2019
@dcoles
Remove use of deprecated `array.fromstring` method
Loading status checks…
023e627 
Using `array.fromstring` generates a `DeprecationWarning` on current versions of Python.
@dcoles dcoles force-pushed the dcoles:patch-1 branch from bfe504b to 023e627 Nov 22, 2019
@dcoles

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

dcoles commented Nov 22, 2019

@corona10 Issue on bugs.python.org: https://bugs.python.org/issue38897
@corona10 corona10 requested review from vstinner and serhiy-storchaka Nov 24, 2019
@corona10
corona10 approved these changes Nov 24, 2019
View changes
Copy link
Member

corona10 left a comment

@dcoles

Thanks for the contribution to the CPython project!!
PR looks good to me :)

@vstinner @serhiy-storchaka
Dear core developers,
@dcoles is the first time contributor to this project.
Please take a look at his PR when you have a time :)
This PR is simple and clear, so it is expected to take less time to review.
@methane methane merged commit 386d00c into python:master Nov 26, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191122.50 succeeded
Details
bedevere/issue-number Issue number 38897 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 26, 2019

Thanks @dcoles for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 26, 2019
@dcoles @miss-islington
Remove use of deprecated `array.fromstring` method (pythonGH-17332)
25c1e8a 
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 26, 2019

GH-17386 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Nov 26, 2019
@miss-islington @dcoles
Remove use of deprecated `array.fromstring` method (GH-17332)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f86401 
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirkarthi commented Nov 26, 2019

@methane Could this be backported to 3.8 too?
@methane

This comment has been minimized.

Sign in to view
Copy link
Member

methane commented Nov 26, 2019

Oh, I missed it. Thank you.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 26, 2019

Thanks @dcoles for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 26, 2019

GH-17387 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 26, 2019
@dcoles @miss-islington
Remove use of deprecated `array.fromstring` method (pythonGH-17332)
65fc837 
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
miss-islington added a commit that referenced this pull request Nov 26, 2019
@miss-islington @dcoles
Remove use of deprecated `array.fromstring` method (GH-17332)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dadff6f 
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@dcoles @jacobneiltaylor
Remove use of deprecated `array.fromstring` method (pythonGH-17332)
689bb59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@vstinner vstinner

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
8 participants
@dcoles @the-knights-who-say-ni @corona10 @miss-islington @bedevere-bot @tirkarthi @methane @ammaraskar
You can’t perform that action at this time.