Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39007: Add auditing events to functions in winreg #17541

Merged
merged 2 commits into from Dec 9, 2019
Merged

bpo-39007: Add auditing events to functions in winreg #17541

merged 2 commits into from Dec 9, 2019

Conversation

@zooba
Copy link
Member

zooba commented Dec 9, 2019 •
edited by bedevere-bot

This PR also requires the fix in #17540.

https://bugs.python.org/issue39007
zooba added 2 commits Dec 9, 2019
@zooba
bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than rai…
Loading status checks…
d342df3 
…se a deprecation warning
@zooba
bpo-39007: Add auditing events to functions in winreg
Loading status checks…
9da25c0
@zooba zooba requested a review from python/windows-team as a code owner Dec 9, 2019
@zooba zooba merged commit ee17e37 into python:master Dec 9, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191209.35 succeeded
Details
bedevere/issue-number Issue number 39007 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zooba zooba deleted the zooba:bpo-39007 branch Dec 9, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 9, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@zooba @miss-islington
bpo-39007: Add auditing events to functions in winreg (pythonGH-17541)
2cf14ce 
Also allows winreg.CloseKey() to accept same types as other functions.
(cherry picked from commit ee17e37)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 9, 2019

GH-17543 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @zooba
bpo-39007: Add auditing events to functions in winreg (GH-17541)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ac9aae 
Also allows winreg.CloseKey() to accept same types as other functions.
(cherry picked from commit ee17e37)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed OS-windows type-security
Projects
None yet
Milestone
No milestone
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.