bpo-36205: Fix the rusage implementation of time.process_time() #15538

vrajivk · 2019-08-27T03:22:50Z

https://bugs.python.org/issue36205

ned-deily · 2019-08-27T03:43:32Z

Thanks, @vrajivk! That sure looks like it. I'm verifying now. Would you be willing to add a NEWS entry for this using blurb? If not, I will.

ned-deily · 2019-08-27T03:48:53Z

Yes, that indeed is the problem and the solution: fix verified on 10.11.

vrajivk · 2019-08-27T03:55:13Z

@ned-deily I took a stab at the NEWS entry via blurb. This is my first PR, so please edit as needed (or let me know if I should make changes). Thanks!

miss-islington · 2019-08-27T04:13:15Z

Thanks @vrajivk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-08-27T04:13:25Z

GH-15539 is a backport of this pull request to the 3.8 branch.

…onGH-15538) (cherry picked from commit 8bf5fef) Co-authored-by: vrajivk <3413293+vrajivk@users.noreply.github.com>

bedevere-bot · 2019-08-27T04:13:32Z

GH-15540 is a backport of this pull request to the 3.7 branch.

…5538) (cherry picked from commit 8bf5fef) Co-authored-by: vrajivk <3413293+vrajivk@users.noreply.github.com>

bedevere-bot · 2019-08-27T04:43:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD CURRENT Shared 3.x has failed when building commit 8bf5fef.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/168/builds/1356) and take a look at the build logs.
Check if the failure is related to this commit (8bf5fef) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/168/builds/1356

Failed tests:

test_os

Summary of the results of the build (if available):

==

Click to see traceback logs

From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_tcl skipped -- No module named '_tkinter'
test_idle skipped -- No module named '_tkinter'
test_epoll skipped -- test works only on Linux 2.6
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_ttk_textonly skipped -- No module named '_tkinter'
test_devpoll skipped -- test works only on Solaris OS family
test_ttk_guionly skipped -- No module named '_tkinter'
test_startfile skipped -- object <module 'os' from '/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/os.py'> has no attribute 'startfile'
test_spwd skipped -- No module named 'spwd'
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_d4ebe508': [Errno 2] No such file or directory: '/psm_d4ebe508'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_tix skipped -- No module named '_tkinter'
test_winsound skipped -- No module named 'winsound'
test_dbm_gnu skipped -- No module named '_gdbm'
test_tk skipped -- No module named '_tkinter'
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_98b0b265': [Errno 2] No such file or directory: '/psm_98b0b265'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_ioctl skipped -- Unable to open /dev/tty
test_winreg skipped -- No module named 'winreg'
test_gdb skipped -- Couldn't find gdb on the path
test_turtle skipped -- No module named '_tkinter'
test_msilib skipped -- No module named '_msi'
test_winconsoleio skipped -- test only relevant on win32
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... skipped 'need select.epoll'
test_kqueue (__main__.SelectEINTRTest) ... ok
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 9.423s

OK (skipped=2)
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_ee1edd6a': [Errno 2] No such file or directory: '/psm_ee1edd6a'
  warnings.warn('resource_tracker: %r: %s' % (name, e))

bedevere-bot · 2019-08-27T05:40:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD CURRENT Shared 3.8 has failed when building commit 91020fa.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/212/builds/128) and take a look at the build logs.
Check if the failure is related to this commit (91020fa) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/212/builds/128

Failed tests:

test_os

Summary of the results of the build (if available):

==

Click to see traceback logs

From https://github.com/python/cpython
 * branch                  3.8        -> FETCH_HEAD
Reset branch '3.8'

test_devpoll skipped -- test works only on Solaris OS family
test_tcl skipped -- No module named '_tkinter'
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_09bcb0d3': [Errno 2] No such file or directory: '/psm_09bcb0d3'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_spwd skipped -- No module named 'spwd'
test_ioctl skipped -- Unable to open /dev/tty
test_tix skipped -- No module named '_tkinter'
test_msilib skipped -- No module named '_msi'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... skipped 'need select.epoll'
test_kqueue (__main__.SelectEINTRTest) ... ok
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 11.265s

OK (skipped=2)
test_winreg skipped -- No module named 'winreg'
test_dbm_gnu skipped -- No module named '_gdbm'
test_startfile skipped -- object <module 'os' from '/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/os.py'> has no attribute 'startfile'
test_tk skipped -- No module named '_tkinter'
test_winsound skipped -- No module named 'winsound'
test_ttk_textonly skipped -- No module named '_tkinter'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_turtle skipped -- No module named '_tkinter'
test_gdb skipped -- Couldn't find gdb on the path
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_d269f4e2': [Errno 2] No such file or directory: '/psm_d269f4e2'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_ttk_guionly skipped -- No module named '_tkinter'
test_idle skipped -- No module named '_tkinter'
test_epoll skipped -- test works only on Linux 2.6
test_winconsoleio skipped -- test only relevant on win32
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/home/buildbot/python/3.8.koobs-freebsd-current/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '/psm_fe320210': [Errno 2] No such file or directory: '/psm_fe320210'
  warnings.warn('resource_tracker: %r: %s' % (name, e))

…onGH-15538)

bpo-36205: Fix the rusage implementation of time.process_time()

827292d

vrajivk requested review from abalkin and pganssle as code owners August 27, 2019 03:22

the-knights-who-say-ni added the CLA signed label Aug 27, 2019

bedevere-bot added the awaiting review label Aug 27, 2019

📜🤖 Added by blurb_it.

5bcc3c6

ned-deily added needs backport to 3.7 labels Aug 27, 2019

ned-deily merged commit 8bf5fef into python:master Aug 27, 2019

bedevere-bot removed the awaiting review label Aug 27, 2019

bedevere-bot removed the needs backport to 3.8 label Aug 27, 2019

bedevere-bot removed the needs backport to 3.7 label Aug 27, 2019

miss-islington added a commit that referenced this pull request Aug 27, 2019

bpo-36205: Fix the rusage implementation of time.process_time() (GH-1…

1bf672f

…5538) (cherry picked from commit 8bf5fef) Co-authored-by: vrajivk <3413293+vrajivk@users.noreply.github.com>

miss-islington added a commit that referenced this pull request Aug 27, 2019

bpo-36205: Fix the rusage implementation of time.process_time() (GH-1…

91020fa

…5538) (cherry picked from commit 8bf5fef) Co-authored-by: vrajivk <3413293+vrajivk@users.noreply.github.com>

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-36205: Fix the rusage implementation of time.process_time() (pyth…

3138817

…onGH-15538)

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-36205: Fix the rusage implementation of time.process_time() (pyth…

f4c6bfa

…onGH-15538)

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-36205: Fix the rusage implementation of time.process_time() (pyth…

3af3e19

…onGH-15538)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-36205: Fix the rusage implementation of time.process_time() #15538

bpo-36205: Fix the rusage implementation of time.process_time() #15538

Uh oh!

vrajivk commented Aug 27, 2019 •

edited by bedevere-bot

Loading

Uh oh!

ned-deily commented Aug 27, 2019

Uh oh!

ned-deily commented Aug 27, 2019

Uh oh!

vrajivk commented Aug 27, 2019

Uh oh!

miss-islington commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

bpo-36205: Fix the rusage implementation of time.process_time() #15538

bpo-36205: Fix the rusage implementation of time.process_time() #15538

Uh oh!

Conversation

vrajivk commented Aug 27, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ned-deily commented Aug 27, 2019

Uh oh!

ned-deily commented Aug 27, 2019

Uh oh!

vrajivk commented Aug 27, 2019

Uh oh!

miss-islington commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

Uh oh!

bedevere-bot commented Aug 27, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 27, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

vrajivk commented Aug 27, 2019 •

edited by bedevere-bot

Loading