bpo-38480: resource.setrlimit() should raise PermissionError #16804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyangyu
requested changes
Oct 19, 2019
There was a problem hiding this comment.
The whatsnew and changelog are wrong. It's ValueError and setrlimit. And the document of setrlimit should also be updated. Currently it says: raises ValueError if a process tries to raise its hard limit. I think we need a versionchanged in 3.9 documents when a not super user do this PermissionError is raised.
|
When you're done making the requested changes, leave the comment: |
|
@giampaolo, please take a look at the code review. Thanks! |
|
@zhangyangyu could you please take one last look? |
zhangyangyu
approved these changes
Feb 6, 2020
zhangyangyu
changed the title
zhangyangyu
requested changes
Feb 6, 2020
| @@ -0,0 +1,2 @@ | |||
| resource.setrusage() now raises PermissionError instead of KeyError if the | |||
|
When you're done making the requested changes, leave the comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://bugs.python.org/issue38480
https://bugs.python.org/issue38480