Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39431: Mention nonlocal too in assignment quirk #17375

Merged
merged 1 commit into from Jan 23, 2020
Merged

bpo-39431: Mention nonlocal too in assignment quirk #17375

merged 1 commit into from Jan 23, 2020
+4 −4

Conversation

@shanavas786
Copy link
Contributor

shanavas786 commented Nov 25, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39431
@shanavas786
Mention nonlocal too in assignment quirk
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fce63df
@shanavas786 shanavas786 changed the title Mention nonlocal too in assignment quirk bpo-39431: Mention nonlocal too in assignment quirk Jan 23, 2020
@shanavas786 shanavas786 requested a review from terryjreedy Jan 23, 2020
@python python deleted a comment from the-knights-who-say-ni Jan 23, 2020
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 23, 2020

PR with an issue should usually have a blurb, but adding two words is trivial enough to skip it.
@terryjreedy terryjreedy merged commit 7142df5 into python:master Jan 23, 2020
4 checks passed
4 checks passed
Azure Pipelines PR #20191125.5 succeeded
Details
bedevere/issue-number Issue number 39431 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

Thanks @shanavas786 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 23, 2020

GH-18152 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@shanavas786 @miss-islington
bpo-39431: Also mention nonlocal in assignment quirk (pythonGH-17375)
72658e1 
(cherry picked from commit 7142df5)

Co-authored-by: Shanavas M <shanavas.m2@gmail.com>
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @shanavas786
bpo-39431: Also mention nonlocal in assignment quirk (GH-17375)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c12d70 
(cherry picked from commit 7142df5)

Co-authored-by: Shanavas M <shanavas.m2@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 23, 2020

Thanks @shanavas786 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@shanavas786 @miss-islington
bpo-39431: Also mention nonlocal in assignment quirk (pythonGH-17375)
1869803 
(cherry picked from commit 7142df5)

Co-authored-by: Shanavas M <shanavas.m2@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 23, 2020

GH-18153 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @shanavas786
bpo-39431: Also mention nonlocal in assignment quirk (GH-17375)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a2356b 
(cherry picked from commit 7142df5)

Co-authored-by: Shanavas M <shanavas.m2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@shanavas786 @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.