Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39320: Handle unpacking of *values in compiler #17984

Merged
merged 6 commits into from Jan 23, 2020

Conversation

@markshannon
Copy link
Contributor

markshannon commented Jan 13, 2020

Quoting bpo 39320:

We can replace the complex bytecodes used in unpacking with simpler, more focused ones.
Specifically the collection building operations:

  • BUILD_LIST_UNPACK
  • BUILD_TUPLE_UNPACK
  • BUILD_SET_UNPACK
  • BUILD_TUPLE_UNPACK_WITH_CALL
    can be replaced with simpler, and self-explanatory operations:
  • LIST_TO_TUPLE
  • LIST_EXTEND,
  • SET_UPDATE

This PR implements those changes. (The proposed changes to ** unpacking will be implemented in another PR).

https://bugs.python.org/issue39320

@markshannon markshannon force-pushed the markshannon:handle-unpacking-in-compiler branch 2 times, most recently from 1f851c4 to 5dbab06 Jan 15, 2020
@markshannon markshannon force-pushed the markshannon:handle-unpacking-in-compiler branch from 5dbab06 to f920034 Jan 15, 2020
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 22, 2020

🤖 New build scheduled with the buildbot fleet by @markshannon for commit f920034 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@markshannon

This comment has been minimized.

Copy link
Contributor Author

markshannon commented Jan 23, 2020

The PPC64 Fedora failure is a pre-existing problem.

@markshannon markshannon merged commit 13bc139 into python:master Jan 23, 2020
43 of 44 checks passed
43 of 44 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
buildbot/PPC64 Fedora PR Build done.
Details
Azure Pipelines PR #20200115.19 succeeded
Details
bedevere/issue-number Issue number 39320 found
Details
bedevere/news News entry found in Misc/NEWS.d
buildbot/AMD64 Arch Linux TraceRefs PR Build done.
Details
buildbot/AMD64 Debian PGO PR Build done.
Details
buildbot/AMD64 Debian root PR Build done.
Details
buildbot/AMD64 Fedora Stable Clang Installed PR Build done.
Details
buildbot/AMD64 Fedora Stable Clang PR Build done.
Details
buildbot/AMD64 Fedora Stable LTO + PGO PR Build done.
Details
buildbot/AMD64 Fedora Stable LTO PR Build done.
Details
buildbot/AMD64 Fedora Stable PR Build done.
Details
buildbot/AMD64 Fedora Stable Refleaks PR Build done.
Details
buildbot/AMD64 FreeBSD Non-Debug PR Build done.
Details
buildbot/AMD64 FreeBSD Shared PR Build done.
Details
buildbot/AMD64 RHEL7 LTO + PGO PR Build done.
Details
buildbot/AMD64 RHEL7 LTO PR Build done.
Details
buildbot/AMD64 RHEL7 PR Build done.
Details
buildbot/AMD64 RHEL7 Refleaks PR Build done.
Details
buildbot/AMD64 RHEL8 LTO + PGO PR Build done.
Details
buildbot/AMD64 RHEL8 LTO PR Build done.
Details
buildbot/AMD64 RHEL8 PR Build done.
Details
buildbot/AMD64 RHEL8 Refleaks PR Build done.
Details
buildbot/AMD64 Ubuntu Shared PR Build done.
Details
buildbot/AMD64 Windows10 PR Build done.
Details
buildbot/AMD64 Windows7 SP1 PR Build done.
Details
buildbot/AMD64 Windows8.1 Non-Debug PR Build done.
Details
buildbot/AMD64 Windows8.1 Refleaks PR Build done.
Details
buildbot/ARMv7 Debian buster PR Build done.
Details
buildbot/PPC64LE Fedora PR Build done.
Details
buildbot/s390x Debian PR Build done.
Details
buildbot/s390x RHEL PR Build done.
Details
buildbot/s390x SLES PR Build done.
Details
buildbot/x86 Gentoo Installed with X PR Build done.
Details
buildbot/x86 Gentoo Non-Debug with X PR Build done.
Details
buildbot/x86 Gentoo Refleaks PR Build done.
Details
buildbot/x86 Windows7 PR Build done.
Details
buildbot/x86-64 macOS PR Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markshannon markshannon deleted the markshannon:handle-unpacking-in-compiler branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.