Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-39299: Add more tests for mimetypes and its cli. (GH-17949) #17992

Open
wants to merge 1 commit into
base: 3.8
from
Open

[3.8] bpo-39299: Add more tests for mimetypes and its cli. (GH-17949) #17992

wants to merge 1 commit into from
+85 −5

Conversation

@miss-islington
Copy link

miss-islington commented Jan 13, 2020 •
edited by bedevere-bot

  • Add tests for case insensitive check of types and extensions as fallback.
  • Add tests for data url with no comma.
  • Add tests for read_mime_types.
  • Add tests for the mimetypes cli and refactor main code to private function.
  • Restore mimetypes.knownfiles value at the end of the test.
    (cherry picked from commit d8efc14)

Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com

https://bugs.python.org/issue39299
@tirkarthi @miss-islington
bpo-39299: Add more tests for mimetypes and its cli. (GH-17949)
Loading status checks…
094bd63 
* Add tests for case insensitive check of types and extensions as fallback.
* Add tests for data url with no comma.
* Add tests for read_mime_types.
* Add tests for the mimetypes cli and refactor __main__ code to private function.
* Restore mimetypes.knownfiles value at the end of the test.
(cherry picked from commit d8efc14)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@miss-islington miss-islington requested a review from python/email-team as a code owner Jan 13, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jan 13, 2020
Merged
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 13, 2020

@tirkarthi: Status check is done, and it's a success ✅ .
2 similar comments
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 13, 2020

@tirkarthi: Status check is done, and it's a success ✅ .
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 13, 2020

@tirkarthi: Status check is done, and it's a success ✅ .
@asvetlov

This comment has been minimized.

Sign in to view
Copy link
Contributor

asvetlov commented Jan 13, 2020

@tirkarthi if you (or I or somebody else) approve this PR -- Miss Islington will merge it if tests pass.
It allows approving a backport PR just after the bot creates it; if everything is ok you don't need to touch the PR anymore.
Otherwise, you'll get a GitHub notification that something was wrong and need your attention.
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirkarthi commented Jan 13, 2020

Got it. Is automerging backport on approval a new workflow I am missing? I was slightly surprised by it in one of backport PRs where the PR was merged as I approved it I guess.
@Mariatta

This comment has been minimized.

Sign in to view
Copy link
Member

Mariatta commented Jan 13, 2020

This is pre-existing workflow. Autobackports (created by miss-islington) still require approval from a core dev.
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirkarthi commented Jan 13, 2020

Thanks @Mariatta .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/email-team email-team

Assignees

@tirkarthi tirkarthi

Labels
CLA signed awaiting review skip news type-tests
Projects
None yet
Milestone
No milestone
6 participants
@miss-islington @asvetlov @tirkarthi @Mariatta @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.