Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-39421: Fix posible crash in heapq with custom comparison operators (GH-18118) #18146

Merged
merged 1 commit into from Jan 23, 2020
Merged

[3.6] bpo-39421: Fix posible crash in heapq with custom comparison operators (GH-18118) #18146

merged 1 commit into from Jan 23, 2020
+59 −9

Conversation

@miss-islington
Copy link

miss-islington commented Jan 23, 2020 •
edited by pablogsal

  • bpo-39421: Fix posible crash in heapq with custom comparison operators

Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue39421

Automerge-Triggered-By: @pablogsal
@pablogsal @miss-islington
bpo-39421: Fix posible crash in heapq with custom comparison operators (
Loading status checks…
509a1d8 
GH-18118)

* bpo-39421: Fix posible crash in heapq with custom comparison operators

* fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators

* fixup! fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators
(cherry picked from commit 79f89e6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2020
Merged
@pablogsal
pablogsal approved these changes Jan 23, 2020
View changes
@pablogsal
pablogsal approved these changes Jan 23, 2020
View changes
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..
@pablogsal pablogsal requested a review from ned-deily Jan 23, 2020
@ned-deily ned-deily merged commit c563f40 into python:3.6 Jan 23, 2020
6 checks passed
6 checks passed
Azure Pipelines PR #20200123.35 succeeded
Details
bedevere/issue-number Issue number 39421 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
codecov/patch 100% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-79f89e6-3.6 branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@ned-deily ned-deily

Assignees
No one assigned
Labels
🤖 automerge CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @pablogsal @ned-deily @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.