Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38449: Add URL delimiters test cases #16729

Merged
merged 2 commits into from Dec 1, 2019
Merged

bpo-38449: Add URL delimiters test cases #16729

merged 2 commits into from Dec 1, 2019
+15 −0

Conversation

@corona10
Copy link
Member

corona10 commented Oct 12, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue38449
@corona10 corona10 requested a review from python/email-team as a code owner Oct 12, 2019
@corona10
bpo-38449: Add tricky test cases
Loading status checks…
b43eaa6
@corona10 corona10 force-pushed the corona10:bpo-38449 branch from 00d3635 to b43eaa6 Oct 12, 2019
@corona10 corona10 requested a review from maxking Oct 12, 2019
@maxking
maxking requested changes Oct 12, 2019
View changes
Copy link
Contributor

maxking left a comment

I think semicolon is only one of the tricky case, there could be others which would result in a similar error case, especially the delimiters for various parts of a URL:

  scheme://netloc/path;parameters?query#fragment

So, I think, ;, ? and # would have similar behaviour when parsing using urllib.parse.urlparse for determining the mimetype.
Lib/test/test_mimetypes.py Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 12, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member Author

corona10 commented Oct 12, 2019

Thanks for the review.
I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 12, 2019

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from maxking Oct 12, 2019
@corona10 corona10 force-pushed the corona10:bpo-38449 branch from 1d104ff to b104b4b Oct 12, 2019
@corona10 corona10 changed the title bpo-38449: Add tricky test cases bpo-38449: Add URL delimiters test cases Oct 12, 2019
@corona10
bpo-38449: Reflect codereview
Loading status checks…
bc52ae5
@corona10 corona10 force-pushed the corona10:bpo-38449 branch from 816c8f7 to bc52ae5 Oct 12, 2019
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member Author

corona10 commented Nov 10, 2019

@maxking gentle ping~
@maxking maxking merged commit 2fe4c48 into python:master Dec 1, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191012.24 succeeded
Details
bedevere/issue-number Issue number 38449 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

@maxking: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 1, 2019

Thanks @corona10 for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 1, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

GH-17431 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@corona10 @miss-islington
bpo-38449: Add URL delimiters test cases (pythonGH-16729)
a4f0e14 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 1, 2019

Thanks @corona10 for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@corona10 @miss-islington
bpo-38449: Add URL delimiters test cases (pythonGH-16729)
141c184 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

GH-17432 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @corona10
bpo-38449: Add URL delimiters test cases (GH-16729)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
926eabb 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @corona10
bpo-38449: Add URL delimiters test cases (GH-16729)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4f1eaf0 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10 @jacobneiltaylor
bpo-38449: Add URL delimiters test cases (python#16729)
16b6604 
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
@corona10 corona10 deleted the corona10:bpo-38449 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxking maxking

Assignees

@maxking maxking

Labels
CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants
@corona10 @bedevere-bot @miss-islington @maxking @the-knights-who-say-ni
You can’t perform that action at this time.