Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] Slightly improve plistlib test coverage. (GH-17025) #17028

Merged
merged 1 commit into from Nov 2, 2019
Merged

[3.8] Slightly improve plistlib test coverage. (GH-17025) #17028

merged 1 commit into from Nov 2, 2019

Conversation

bigfootjon
Copy link
Contributor

@bigfootjon bigfootjon commented Nov 1, 2019

  • Add missing test class (mistake in bpo-32072: Fix issues with binary plists. #4455)

  • Increase coverage with 4 more test cases

  • Rename neg_uid to huge_uid in test_modified_uid_huge

  • Replace test_main() with unittest.main()

  • Update plistlib docs.
    (cherry picked from commit d0d9f7c)

Co-authored-by: Jon Janzen jjjonjanzen@gmail.com

@bigfootjon
[3.8] Slightly improve plistlib test coverage. (GH-17025)
f8ccebc 
* Add missing test class (mistake in GH-4455)

* Increase coverage with 4 more test cases

* Rename neg_uid to huge_uid in test_modified_uid_huge

* Replace test_main() with unittest.main()

* Update plistlib docs.
(cherry picked from commit d0d9f7c)

Co-authored-by: Jon Janzen <jjjonjanzen@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2019
Merged
@serhiy-storchaka serhiy-storchaka merged commit fe934e1 into python:3.8 Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bigfootjon @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot