Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38753: AsyncMock added in version 3.8 #17102

Merged
merged 1 commit into from Nov 20, 2019
Merged

bpo-38753: AsyncMock added in version 3.8 #17102

merged 1 commit into from Nov 20, 2019
+1 −0

Conversation

@belm0
Copy link
Contributor

belm0 commented Nov 10, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue38753
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Nov 10, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@belm0

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@belm0

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

belm0 commented Nov 10, 2019

CLA submitted
needs backport to 3.8 🙏
@tirkarthi
tirkarthi reviewed Nov 10, 2019
View changes
Doc/library/unittest.mock.rst Outdated Show resolved Hide resolved
@belm0
bpo-38753: AsyncMock added in version 3.8
Loading status checks…
80c463f
@belm0 belm0 force-pushed the belm0:patch-1 branch from e05c93a to 80c463f Nov 10, 2019
@belm0

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

belm0 commented Nov 10, 2019

I think bpo associated this PR with my older bpo account, which doesn't have a CLA. I'll submit a CLA for that account as well...

https://bugs.python.org/pull_request16608
@belm0

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

belm0 commented Nov 10, 2019

please add 3.8 backport tag
@tirkarthi
tirkarthi approved these changes Nov 10, 2019
View changes
Copy link
Contributor

tirkarthi left a comment

I think adding it before "An asynchronous version of :class:Mock. The :class:AsyncMock" paragraph would be ideal. I will leave it to the core dev merging this. It will be backported to 3.8 once merged. Thanks :)
@aeros
aeros approved these changes Nov 12, 2019
View changes
Copy link
Member

aeros left a comment

Thanks for the PR @belm0.

@tirkarthi

I think adding it before "An asynchronous version of :class:Mock. The :class:AsyncMock" paragraph would be ideal.

The most common formats I've seen across the docs are:

..type:: callable(*args, **kwargs)

Summary

Example(s)

Version added

..type:: callable(*args, **kwargs)

Summary

Version added

Example(s)

The most common one seems to be (1), which is essentially the current placement of the versionadded added notice in the PR, so I think the current location is fine. For an example of (1), see https://docs.python.org/3/library/asyncio-task.html#asyncio.run.
@belm0

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

belm0 commented Nov 14, 2019

is CLA process broken? I submitted doc about 4 days ago.
@aeros

This comment has been minimized.

Sign in to view
Copy link
Member

aeros commented Nov 15, 2019

@belm0

is CLA process broken? I submitted doc about 4 days ago.

Try manually updating the GitHub CLA status via https://check-python-cla.herokuapp.com/, I recall having to do that for my first PR.
@lisroach

This comment has been minimized.

Sign in to view
Copy link
Contributor

lisroach commented Nov 20, 2019

LGTM, thanks for adding this :)
@lisroach
lisroach approved these changes Nov 20, 2019
View changes
@lisroach lisroach merged commit 279d8df into python:master Nov 20, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191110.9 succeeded
Details
bedevere/issue-number Issue number 38753 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 20, 2019

Thanks @belm0 for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
@belm0 @miss-islington
bpo-38753: AsyncMock added in version 3.8 (pythonGH-17102)
fbfba1b 
(cherry picked from commit 279d8df)

Co-authored-by: John Belmonte <john@neggie.net>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 20, 2019

GH-17268 is a backport of this pull request to the 3.8 branch.
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@belm0 @jacobneiltaylor
bpo-38753: AsyncMock added in version 3.8 (pythonGH-17102)
44367db
miss-islington added a commit that referenced this pull request Dec 25, 2019
@miss-islington @belm0
bpo-38753: AsyncMock added in version 3.8 (GH-17102)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8c0f001 
(cherry picked from commit 279d8df)

Co-authored-by: John Belmonte <john@neggie.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@lisroach lisroach

@aeros aeros

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
9 participants
@belm0 @the-knights-who-say-ni @aeros @lisroach @miss-islington @bedevere-bot @tirkarthi @ammaraskar @brandtbucher
You can’t perform that action at this time.