Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38816: Add notes in the C-API docs about fork in subinterpreters. #17176

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Nov 15, 2019

The C-API docs are a bit sparse on the interplay between C fork() and the CPython runtime. This change adds some more information on the subject.

https://bugs.python.org/issue38816

Automerge-Triggered-By: @ericsnowcurrently

@ericsnowcurrently ericsnowcurrently requested a review from gpshead Nov 15, 2019
@bedevere-bot bedevere-bot added docs awaiting core review labels Nov 15, 2019
@ericsnowcurrently ericsnowcurrently changed the title Add notes in the C-API docs about fork in subinterpreters. bpo-38816: Add notes in the C-API docs about fork in subinterpreters. Nov 15, 2019
@gpshead
Copy link
Member

@gpshead gpshead commented Nov 15, 2019

overall this makes sense. I wonder if there might be more nuance here as this is discussing the C level fork() syscall, but I don't think it is worth trying to go into and explain that if there is. :)

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Nov 15, 2019
@miss-islington miss-islington merged commit 73cdb0c into python:master Nov 15, 2019
4 checks passed
@ericsnowcurrently ericsnowcurrently deleted the docs-capi-fork-in-main-interpreter branch Nov 15, 2019
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 15, 2019

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 15, 2019

GH-17178 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this issue Nov 15, 2019
…GH-17176)

The C-API docs are a bit sparse on the interplay between C `fork()` and the CPython runtime.  This change adds some more information on the subject.

https://bugs.python.org/issue38816
(cherry picked from commit 73cdb0c)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
jacksonriley pushed a commit to jacksonriley/cpython that referenced this issue Nov 18, 2019
…pythonGH-17176)

The C-API docs are a bit sparse on the interplay between C `fork()` and the CPython runtime.  This change adds some more information on the subject.


https://bugs.python.org/issue38816
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this issue Dec 5, 2019
…pythonGH-17176)

The C-API docs are a bit sparse on the interplay between C `fork()` and the CPython runtime.  This change adds some more information on the subject.


https://bugs.python.org/issue38816
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Jan 31, 2020
…pythonGH-17176)

The C-API docs are a bit sparse on the interplay between C `fork()` and the CPython runtime.  This change adds some more information on the subject.


https://bugs.python.org/issue38816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed docs 🤖 automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants