Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing markup #17680

Merged
merged 1 commit into from Dec 22, 2019
Merged

Add missing markup #17680

merged 1 commit into from Dec 22, 2019

Conversation

@cocoatomo
Copy link
Contributor

cocoatomo commented Dec 22, 2019 •
edited by miss-islington

"HH", "MM" and "ffffff" are enclosed with double back quotes, but "SS" is left being bare

Automerge-Triggered-By: @Mariatta
@cocoatomo
Add missing markup
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e86673d 
"HH", "MM" and "ffffff" are enclosed with double back quotes, but "SS" is left being bare
@cocoatomo cocoatomo requested review from abalkin and pganssle as code owners Dec 22, 2019
@Mariatta
Mariatta approved these changes Dec 22, 2019
View changes
@miss-islington miss-islington merged commit 068768f into python:master Dec 22, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191222.4 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 22, 2019

Thanks @cocoatomo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@Mariatta

This comment has been minimized.

Sign in to view
Copy link
Member

Mariatta commented Dec 22, 2019

Thanks!
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 22, 2019

GH-17681 is a backport of this pull request to the 3.8 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 22, 2019

Sorry, @cocoatomo, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 068768faf6b82478de239d7ab903dfb249ad96a4 3.7
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 22, 2019
@cocoatomo @miss-islington
Add missing markup (pythonGH-17680)
8bba50a 
"HH", "MM" and "ffffff" are enclosed with double back quotes, but "SS" is left being bare
(cherry picked from commit 068768f)

Co-authored-by: cocoatomo <cocoatomo77@gmail.com>
@miss-islington miss-islington self-assigned this Dec 22, 2019
miss-islington added a commit that referenced this pull request Dec 22, 2019
@miss-islington @cocoatomo
Add missing markup (GH-17680)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
35590c5 
"HH", "MM" and "ffffff" are enclosed with double back quotes, but "SS" is left being bare
(cherry picked from commit 068768f)

Co-authored-by: cocoatomo <cocoatomo77@gmail.com>
sthagen added a commit to sthagen/cpython that referenced this pull request Dec 22, 2019
@sthagen
Merge pull request #114 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bf33621 
Add missing markup (pythonGH-17680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

@abalkin abalkin

@pganssle pganssle

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed needs backport to 3.7 skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@cocoatomo @miss-islington @Mariatta @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.