Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that test.test_distutils can be executed by unittest and not j… #13480

Merged
merged 1 commit into from Jan 27, 2020

Conversation

@abadger
Copy link
Contributor

abadger commented May 22, 2019

…ust regrtest

Our developer instructions list unittest with test discovery as the
method to execute individual tests so we should make that work. This is
similar to add7cbf but for testing
distutils rather than testing unittest. For instance, this change will
enable the following to work:

./python -m unittest -v distutils.tests.test_file_util

@abadger

This comment has been minimized.

Copy link
Contributor Author

abadger commented May 22, 2019

@merwok hey, here's a fix to enable the distutils test suite to work with unittest as well as regrtest. The strategy was copied from Michael Foord's change to the test_unittest.py file.

Let me know if you'd like me to open a bug (and if you'd like me to add a NEWS entry). I wasn't sure if this was so trivial that it didn't need either of those.

…ust regrtest

Our developer instructions list unittest with test discovery as the
method to execute individual tests so we should make that work.  This is
similar to add7cbf but for testing
distutils rather than testing unittest.  For instance, this change will
enable the following to work:

./python -m unittest -v distutils.tests.test_file_util
@abadger abadger force-pushed the abadger:enable-distutils-unittests branch from 41544f2 to 5491c5e May 22, 2019
@auvipy
auvipy approved these changes Jun 1, 2019
@csabella csabella requested a review from merwok Jan 26, 2020
@merwok
merwok approved these changes Jan 27, 2020
@csabella csabella merged commit 997443c into python:master Jan 27, 2020
5 checks passed
5 checks passed
Azure Pipelines PR #20190522.4 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.