Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39377: json: Remove encoding option. #18075

Merged
merged 2 commits into from Jan 20, 2020
Merged

bpo-39377: json: Remove encoding option. #18075

merged 2 commits into from Jan 20, 2020

Conversation

@methane
Copy link
Member

methane commented Jan 20, 2020 •
edited

bpo-39377
@methane
bpo-39377: json: Remove encoding option.
Loading status checks…
72597c6
@ammaraskar
ammaraskar reviewed Jan 20, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-20-13-00-35.bpo-39377.QSFdaU.rst Outdated Show resolved Hide resolved
@methane @ammaraskar
Update Misc/NEWS.d/next/Library/2020-01-20-13-00-35.bpo-39377.QSFdaU.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
605b23a 
Co-Authored-By: Ammar Askar <ammar_askar@hotmail.com>
@ammaraskar
ammaraskar approved these changes Jan 20, 2020
View changes
@methane methane merged commit 5492bfc into python:master Jan 20, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200120.6 succeeded
Details
bedevere/issue-number Issue number 39377 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane methane deleted the methane:remove-json-encoding branch Jan 20, 2020
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 20, 2020
@sthagen
Merge pull request #193 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee4c047 
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
@ammaraskar

This comment has been minimized.

Sign in to view
Copy link
Member

ammaraskar commented Jan 20, 2020

Oh sorry, I missed that there was a mention of encoding in https://github.com/python/cpython/blob/master/Doc/library/json.rst on line 286:

The other arguments have the same meaning as in :func:load, except
encoding which is ignored and deprecated since Python 3.1.

Should this be removed as well?
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@methane @petdance
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
74162db
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@methane @petdance
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
f4a2530
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@methane @petdance
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
641f4fc
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@methane @petdance
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
3d04164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@methane @ammaraskar @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.