bpo-36548: Improve the repr of re flags. #12715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainDe
reviewed
Apr 13, 2019
| M = MULTILINE | ||
| S = DOTALL | ||
| X = VERBOSE | ||
| ASCII = A = sre_compile.SRE_FLAG_ASCII # assume ascii "locale" |
There was a problem hiding this comment.
Not related to the issue you are solving (but as you're updating this code anyway):
- the alignment may be more aesthetically pleasing if the one latter variable was the first here
- PEP8 recommends using at least 2 whitespace before the inline comment
There was a problem hiding this comment.
In case of aliases the canonical name is the one that is defined first. We want to use long names.
There was a problem hiding this comment.
Some lines are already too long, and using two spaces will make them even longer.
| else: | ||
| res = f'~{res}' | ||
| return res | ||
| __str__ = object.__str__ |
There was a problem hiding this comment.
As you're adding this line, would it be worth adding a few test cases for it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue36548