Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Replace the deprecated highlightlang directive by highlight. #13377

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented May 17, 2019

highlightlang is deprecated since April 2018 in Sphinx and will be removed in Sphinx 4.0
See sphinx-doc/sphinx#4845

@JulienPalard for the skip news I am not sure because we will stop to use .. highlightlang :: and it's not a feature/bugfix of Python.

highlightlang is deprecated since April 2018 in Sphinx.
See sphinx-doc/sphinx#4845
Copy link
Member

@kushaldas kushaldas left a comment

The change looks good, the docs built from this branch looks exactly the same like in the old version.
There are no more instance of hightlightlang left in the Doc/ directory.

@kushaldas kushaldas merged commit cbb6484 into python:master May 17, 2019
5 checks passed
@bedevere-bot
Copy link

bedevere-bot commented May 17, 2019

@kushaldas: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants