Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39430: Fix race condition in lazy imports in tarfile. #18161

Merged
merged 1 commit into from Jan 24, 2020
Merged

bpo-39430: Fix race condition in lazy imports in tarfile. #18161

merged 1 commit into from Jan 24, 2020
+9 −10

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 24, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39430
@serhiy-storchaka serhiy-storchaka requested a review from ethanfurman as a code owner Jan 24, 2020
@serhiy-storchaka
bpo-39430: Fix race condition in lazy imports in tarfile.
Loading status checks…
a38da42
@serhiy-storchaka serhiy-storchaka force-pushed the serhiy-storchaka:tarfile-import-race-condition branch from a6d9268 to a38da42 Jan 24, 2020
@brettcannon
brettcannon approved these changes Jan 24, 2020
View changes
@ethanfurman
ethanfurman approved these changes Jan 24, 2020
View changes
@ethanfurman ethanfurman merged commit 9017e0b into python:master Jan 24, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200124.21 succeeded
Details
bedevere/issue-number Issue number 39430 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 24, 2020

Thanks @serhiy-storchaka for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 24, 2020
@serhiy-storchaka @miss-islington
bpo-39430: Fix race condition in lazy imports in tarfile. (pythonGH-1…
29a6661 
…8161)

Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0bd5e124ae6d2ed94b9e9cacb2e86270980)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 24, 2020

GH-18171 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 24, 2020
@serhiy-storchaka @miss-islington
bpo-39430: Fix race condition in lazy imports in tarfile. (pythonGH-1…
d240383 
…8161)

Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 24, 2020

GH-18172 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 24, 2020
@miss-islington @serhiy-storchaka
bpo-39430: Fix race condition in lazy imports in tarfile. (GH-18161)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea4a61f 
Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jan 24, 2020
@miss-islington @serhiy-storchaka
bpo-39430: Fix race condition in lazy imports in tarfile. (GH-18161)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a27435 
Use `from ... import ...` to ensure module is fully loaded before accessing its attributes.
(cherry picked from commit 9017e0b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@ethanfurman ethanfurman

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@serhiy-storchaka @miss-islington @bedevere-bot @brettcannon @ethanfurman @the-knights-who-say-ni
You can’t perform that action at this time.