Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36350: inspect: Replace OrderedDict with dict. #12412

Merged
merged 8 commits into from Jan 28, 2020
Merged

bpo-36350: inspect: Replace OrderedDict with dict. #12412

merged 8 commits into from Jan 28, 2020
+39 −29

Conversation

@remilapeyre
Copy link
Contributor

remilapeyre commented Mar 18, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue36350
remilapeyre added 2 commits Mar 18, 2019
@remilapeyre
Add test for type of inspect.{Signature.parameters,BoundArguments.arg…
59631c9 
…uments}
@remilapeyre
Change type of inspect.{Signature.parameters,BoundArguments.arguments}
Loading status checks…
9173550
@matrixise
matrixise reviewed Mar 18, 2019
View changes
Lib/inspect.py Show resolved Hide resolved
@remilapeyre
Remove useless test
Loading status checks…
f0fc69a
@tirkarthi
tirkarthi reviewed Mar 18, 2019
View changes
Lib/inspect.py Show resolved Hide resolved
@remilapeyre remilapeyre reopened this Mar 18, 2019
@rhettinger
rhettinger requested changes Mar 18, 2019
View changes
Doc/library/inspect.rst Outdated Show resolved Hide resolved
Lib/inspect.py Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Mar 18, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@remilapeyre
Indicate former type in versionchanged
Loading status checks…
caaf117
@remilapeyre remilapeyre force-pushed the remilapeyre:inpect.Signature-BoundArguments-ordereddict branch from aa77813 to caaf117 Mar 18, 2019
@remilapeyre
Keep moving params to the end
Loading status checks…
987ba3c
@remilapeyre

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

remilapeyre commented Mar 20, 2019

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Mar 20, 2019

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.
@csabella csabella requested a review from rhettinger Jan 25, 2020
@methane
Update inspect.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
099b938
@methane
methane requested changes Jan 28, 2020
View changes
Doc/library/inspect.rst Outdated Show resolved Hide resolved
Doc/library/inspect.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 28, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
@methane methane changed the title bpo-36350: Change type of inspect.{Signature.parameters,BoundArguments.arguments} bpo-36350: inspect: Replace OrderedDict with dict. Jan 28, 2020
remilapeyre and others added 2 commits Jan 28, 2020
@remilapeyre @methane
Update versionchanged
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4d4564 
Co-Authored-By: Inada Naoki <songofacandy@gmail.com>
@remilapeyre @methane
Update versionchanged
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e81f405 
Co-Authored-By: Inada Naoki <songofacandy@gmail.com>
@methane
methane approved these changes Jan 28, 2020
View changes
@methane methane merged commit 2cca8ef into python:master Jan 28, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200128.30 succeeded
Details
bedevere/issue-number Issue number 36350 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise

@tirkarthi tirkarthi

@methane methane

@rhettinger rhettinger

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
7 participants
@remilapeyre @bedevere-bot @matrixise @methane @rhettinger @tirkarthi @the-knights-who-say-ni
You can’t perform that action at this time.