Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39224: Document None support for HTTPConnection.timeout #17843
Conversation
`timeout` is passed down to `socket.settimeout()` which supports `None` and puts the socket in blocking mode.
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Jan 5, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
I just signed the CLA, does this bot auto-update when it gets approved? I'm unsure on how to add a news reference for this, is anything needed? |
This comment has been minimized.
This comment has been minimized.
|
The CLA bot should update automatically. See https://devguide.python.org/committing/#what-s-new-and-news-entries for how to add a NEWS entry, but since this is a docs-only change I don't think you actually need one. |
dfarley1 commentedJan 5, 2020
•
edited by bedevere-bot
timeoutis passed down tosocket.settimeout()which supportsNoneand puts the socket in blocking mode.I know I'm encountering this in 3.6, I'm willing to bet it goes back further than that.
https://bugs.python.org/issue39224