Skip to content

[3.8] Improve test coverage for AsyncMock. (GH-17906) #18165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

miss-islington
Copy link
Contributor

  • Add test for nested async decorator patch.
  • Add test for side_effect and wraps with a function.
  • Add test for side_effect with an exception in the iterable.
    (cherry picked from commit 54f743e)

Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com

* Add test for nested async decorator patch.
* Add test for side_effect and wraps with a function.
* Add test for side_effect with an exception in the iterable.
(cherry picked from commit 54f743e)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@miss-islington
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miss-islington miss-islington merged commit 0ea7309 into python:3.8 Jan 24, 2020
@miss-islington miss-islington deleted the backport-54f743e-3.8 branch January 24, 2020 13:27
@miss-islington
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants