Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse relative imports in mock and its tests to help backporting #18197
+82
−79
Conversation
|
LGTM since it will help backporting. Maybe we need to add these points about imports to checklist too when changes to mock are made in future to be in line with backport. Thanks Chris. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I can't think of a good place to put such a checklist though. Better suggestions very gratefully received! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cjw296 commentedJan 27, 2020
I stopped short of putting comments at the top of each file explaining the import style, but I've tagged everyone I know of who's active in mock's development right now to ask if you can keep an eye out for
import foo; foo.barusage for things that aren't in Python 3.6+.from foo import barmakes it much easier to backport just what's necessary and stops patches failing to apply cleanly going forwards.@mariocj89 - tagging you too for reference :-)