Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39366: Remove xpath() and xgtitle() methods of NNTP. #18035

Merged
merged 4 commits into from Jan 22, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Jan 17, 2020

@corona10 corona10 requested a review from vstinner Jan 17, 2020
@corona10 corona10 changed the title bpo-39336: Remove xpath() and xgtitle() methods of NNTP. bpo-39366: Remove xpath() and xgtitle() methods of NNTP. Jan 17, 2020
@corona10 corona10 force-pushed the corona10:bpo-39336 branch from b5d47c4 to 3c9748d Jan 17, 2020
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
@corona10 corona10 force-pushed the corona10:bpo-39336 branch from 075d0f2 to e8868ed Jan 17, 2020
Copy link
Member

vstinner left a comment

LGTM. But I would prefer to have a second review, since I'm not used to nntplib.

@serhiy-storchaka @vadmium @berkerpeksag @pitrou: Can one of you please review this PR as well? Well, IMO the PR itself is fine, the question is more if you are ok to drop these two deprecated methods.

Doc/whatsnew/3.9.rst Show resolved Hide resolved
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Lib/nntplib.py Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 19, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member Author

corona10 left a comment

@berkerpeksag

Thanks for the review!
I have made the requested changes; please review again

@corona10 corona10 requested a review from berkerpeksag Jan 20, 2020
Copy link
Member

vstinner left a comment

LGTM. @berkerpeksag: @corona10 addressed your remarks, would you mind to review it again?

Copy link
Member

berkerpeksag left a comment

Looks great, thank you!

@berkerpeksag berkerpeksag merged commit 1f0f102 into python:master Jan 22, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200120.1 succeeded
Details
bedevere/issue-number Issue number 39366 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.