Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39366: Remove xpath() and xgtitle() methods of NNTP. #18035
Conversation
LGTM. But I would prefer to have a second review, since I'm not used to nntplib. @serhiy-storchaka @vadmium @berkerpeksag @pitrou: Can one of you please review this PR as well? Well, IMO the PR itself is fine, the question is more if you are ok to drop these two deprecated methods. |
Misc/NEWS.d/next/Library/2020-01-17-18-14-51.bpo-39366.Cv3NQS.rst
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 19, 2020
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for the review! |
LGTM. @berkerpeksag: @corona10 addressed your remarks, would you mind to review it again? |
Looks great, thank you! |
1f0f102
into
python:master
corona10 commentedJan 17, 2020
•
edited
https://bugs.python.org/issue39366