bpo-35182: fix communicate() crash after child closes its pipes #18117

alpire · 2020-01-22T15:23:04Z

When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running. The fix is trivial.

(Original PR is #17020. I had to create a new one to rebase on top of master & fix merge conflicts)

https://bugs.python.org/issue35182


        bpo-35182: fix communicate() crash after child closes its pipes (GH-1…

…7020) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running

the-knights-who-say-ni · 2020-01-22T15:23:08Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@alpire

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

miss-islington · 2020-01-22T23:28:35Z

Thanks @alpire for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2020-01-22T23:28:36Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington · 2020-01-22T23:28:41Z

Sorry, @alpire and @gpshead, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d3ae95e1e945ed20297e1c38ba43a18b7a868ab6 3.7

miss-islington · 2020-01-22T23:29:31Z

Thanks @alpire for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2020-01-22T23:29:33Z

Sorry @alpire and @gpshead, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d3ae95e1e945ed20297e1c38ba43a18b7a868ab6 3.8

miss-islington · 2020-01-22T23:29:58Z

Thanks @alpire for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2020-01-22T23:30:00Z

Sorry, @alpire and @gpshead, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d3ae95e1e945ed20297e1c38ba43a18b7a868ab6 3.7


        [3.8] bpo-35182: fix communicate() crash after child closes its pipes (…

…pythonGH-17020) (pythonGH-18117) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com>

bedevere-bot · 2020-01-23T14:56:43Z

GH-18148 is a backport of this pull request to the 3.8 branch.


        [3.7] bpo-35182: fix communicate() crash after child closes its pipes (…

…pythonGH-17020) (pythonGH-18117) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com>

bedevere-bot · 2020-01-23T15:18:44Z

GH-18151 is a backport of this pull request to the 3.7 branch.


        [3.8] bpo-35182: fix communicate() crash after child closes its pipes (…

…GH-18117) (GH-18148) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com> https://bugs.python.org/issue35182


        [3.7] bpo-35182: fix communicate() crash after child closes its pipes (…

@gpshead

…GH-18117) (GH-18151) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com> https://bugs.python.org/issue35182 Automerge-Triggered-By: @gpshead

bpo-35182: fix communicate() crash after child closes its pipes (GH-1…

Loading status checks…

35fd4c9

…7020) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running

alpire requested a review from gpshead as a code owner Jan 22, 2020

the-knights-who-say-ni added the CLA not signed label Jan 22, 2020

bedevere-bot added the awaiting review label Jan 22, 2020

alpire mentioned this pull request Jan 22, 2020

bpo-35182: fix communicate() crash after child closes its pipes #17020

Closed

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 22, 2020

gpshead approved these changes Jan 22, 2020

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Jan 22, 2020

gpshead added needs backport to 3.7 needs backport to 3.8 labels Jan 22, 2020

gpshead self-assigned this Jan 22, 2020

bedevere-bot removed the awaiting merge label Jan 22, 2020

gpshead added needs backport to 3.8 and removed needs backport to 3.7 needs backport to 3.8 labels Jan 22, 2020

gpshead added the needs backport to 3.7 label Jan 22, 2020

alpire mentioned this pull request Jan 23, 2020

[3.8] bpo-35182: fix communicate() crash after child closes its pipes (GH-18117) #18148

Merged

bedevere-bot removed the needs backport to 3.8 label Jan 23, 2020

bedevere-bot removed the needs backport to 3.7 label Jan 23, 2020

python / cpython

bpo-35182: fix communicate() crash after child closes its pipes #18117

bpo-35182: fix communicate() crash after child closes its pipes #18117

alpire commented Jan 22, 2020 •

edited

This comment has been minimized.

the-knights-who-say-ni commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

bedevere-bot commented Jan 23, 2020

This comment has been minimized.

bedevere-bot commented Jan 23, 2020

python / cpython

Sponsor python/cpython

Join GitHub today

bpo-35182: fix communicate() crash after child closes its pipes #18117

bpo-35182: fix communicate() crash after child closes its pipes #18117

Conversation

alpire commented Jan 22, 2020 • edited

This comment has been minimized.

the-knights-who-say-ni commented Jan 22, 2020

CLA Missing

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

miss-islington commented Jan 22, 2020

This comment has been minimized.

bedevere-bot commented Jan 23, 2020

This comment has been minimized.

bedevere-bot commented Jan 23, 2020

alpire commented Jan 22, 2020 •

edited