Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-39390 shutil: fix argument types for ignore callback (GH-18122). #18168

Open
wants to merge 1 commit into
base: 3.8
from
Open

[3.8] bpo-39390 shutil: fix argument types for ignore callback (GH-18122). #18168

wants to merge 1 commit into from
+45 −1

Conversation

@mbarkhau
Copy link
Contributor

mbarkhau commented Jan 24, 2020 •
edited by bedevere-bot

(cherry picked from commit 8870433)

Co-authored-by: mbarkhau mbarkhau@gmail.com

https://bugs.python.org/issue39390
@mbarkhau
[3.8] bpo-39390 shutil: fix argument types for ignore callback (GH-18122
Loading status checks…
778ba9c 
).

(cherry picked from commit 8870433)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2020
Merged
@mbarkhau mbarkhau requested a review from giampaolo Jan 24, 2020
@giampaolo

This comment has been minimized.

Sign in to view
Copy link
Contributor

giampaolo commented Jan 24, 2020

Since this is a regression, I think it deserves an entry at the bottom of Docs/whatsnew:

Notable changes in Python 3.8.2
===============================

Fixed a regression with the `ignore` callback of :func:`shutil.copytree`.
The argument types are now str and List[str] again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giampaolo giampaolo

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
4 participants
@mbarkhau @giampaolo @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.