Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-34977: Add Windows App Store package #11027
Conversation
|
Please move the venv and tests change into a separated PR. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 7, 2018
|
When you're done making the requested changes, leave the comment: |
This comment has been minimized.
This comment has been minimized.
|
Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-) |
This comment has been minimized.
This comment has been minimized.
|
How do you trigger a custom build these days? I couldn't find the UI. |
This comment has been minimized.
This comment has been minimized.
It's basically just a Git push to the right branch: See https://devguide.python.org/buildbots/#custom-builders for more info. Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-) |
This comment has been minimized.
This comment has been minimized.
|
I have made the requested changes; please review again |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 10, 2018
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
|
A couple of minor points, but generally this looks OK to me. |
Also adds the PC/layout script for generating layouts on Windows.
zooba commentedDec 7, 2018
•
edited by bedevere-bot
Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.
https://bugs.python.org/issue34977