Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39153: Clarify refcounting semantics #18220

Open
wants to merge 3 commits into
base: master
from
Open

bpo-39153: Clarify refcounting semantics #18220

wants to merge 3 commits into from
+14 −6

Conversation

@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Jan 27, 2020 •
edited by bedevere-bot

Clarify refcounting semantics for the following functions:

  • PyObject_SetItem
  • PyMapping_SetItemString
  • PyDict_SetItem
  • PyDict_SetItemString

https://bugs.python.org/issue39153
nanjekyejoannah
Clarify refcounting semantics
Loading status checks…
fa750f2
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
74f6ea8
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Jan 28, 2020

Thanks @nanjekyejoannah; I can't tell you how many times I've had to dig through the source code to remember this!
@nanjekyejoannah

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nanjekyejoannah commented Jan 28, 2020

@ncoghlan and @serhiy-storchaka , if this looks fine, I will merge it.
@corona10
corona10 reviewed Jan 28, 2020
View changes
Copy link
Member

corona10 left a comment

@nanjekyejoannah
Thanks for the great work.
I left some feedback for this PR :)
Misc/NEWS.d/next/Documentation/2020-01-27-22-24-51.bpo-39153.Pjl8jV.rst Outdated Show resolved Hide resolved
Doc/c-api/dict.rst Show resolved Hide resolved
nanjekyejoannah
make docs consistent with signature
Loading status checks…
bbd3b4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
CLA signed awaiting core review type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@nanjekyejoannah @brandtbucher @corona10 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.