Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39453: Fix contains method of list to hold strong references #18181
Conversation
This comment has been minimized.
This comment has been minimized.
@pablogsal @serhiy-storchaka @vstinner |
Misc/NEWS.d/next/Core and Builtins/2020-01-25-23-51-17.bpo-39453.xCOkYk.rst
Outdated
Show resolved
Hide resolved
…lements.
@rhettinger I've updated the PR Please take a look :) |
@@ -0,0 +1,2 @@ | |||
Fix contains method of list to hold strong references of elements while |
This comment has been minimized.
This comment has been minimized.
serhiy-storchaka
Jan 27, 2020
Member
It describes the implementation, but says nothing to an average Python user. I would formulate the entry in terms of Python: "Fixed possible crash in ``list.contains` when a list is changed during comparing items."
This comment has been minimized.
This comment has been minimized.
Misc/NEWS.d/next/Core and Builtins/2020-01-25-23-51-17.bpo-39453.xCOkYk.rst
Outdated
Show resolved
Hide resolved
LGTM with changes proposed by @pablogsal. |
@pablogsal @serhiy-storchaka |
4dbf2d8
into
python:master
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 27, 2020
Thanks @corona10 for the PR, and @pablogsal for merging it |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 27, 2020
Sorry, @corona10 and @pablogsal, I could not cleanly backport this to |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 27, 2020
Sorry @corona10 and @pablogsal, I had trouble checking out the |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 27, 2020
Sorry, @corona10 and @pablogsal, I could not cleanly backport this to |
This comment has been minimized.
This comment has been minimized.
@corona10 Could you make the backports with |
corona10 commentedJan 25, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39453