Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-38960: DTrace build fix for FreeBSD. #17451
Merged
Conversation
- allowing passing an extra flag as it need to define the arch size. - casting some probe's arguments.
dcarlier-afilias
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as
code owners
dcarlier-afilias
changed the title
| @@ -0,0 +1 @@ | |||
| DTrace build fix aimed for FreeBSD | |||
This comment has been minimized.
This comment has been minimized.
brettcannon
Dec 3, 2019
Member
Suggested change
| DTrace build fix aimed for FreeBSD | |
| Fix DTrace build issues on FreeBSD. Patch by David Carlier. |
dcarlier-afilias
force-pushed the
dcarlier-afilias:dtrace_fbsd_build_fix
branch
from
5209d2e
to
36cfbfb
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 14, 2020
This comment has been minimized.
This comment has been minimized.
|
The PPC64 Fedora buildbot failure was unrelated. |
encukou
merged commit aabdeb7
into
python:master
37 of 38 checks passed
37 of 38 checks passed
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dcarlier-afilias commentedDec 3, 2019
•
edited by miss-islington
https://bugs.python.org/issue38960
Automerge-Triggered-By: @encukou