Skip to content

[2.7] bpo-36089: Fix formatting and spelling of SimpleHTTPServer docs #11995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

[2.7] bpo-36089: Fix formatting and spelling of SimpleHTTPServer docs #11995

merged 1 commit into from
Feb 23, 2019

Conversation

alanag13
Copy link

@alanag13 alanag13 commented Feb 23, 2019 •
edited
Loading

Improperly formatted rst is bleeding onto the page and the module name is misspelled.

https://docs.python.org/2/library/simplehttpserver.html

https://bugs.python.org/issue36089

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 23, 2019
@alanag13 alanag13 changed the title bpo-36089: Fix formatting and spelling of SimpleHTTPServer docs [2.7] bpo-36089: Fix formatting and spelling of SimpleHTTPServer docs Feb 23, 2019
tirkarthi
tirkarthi approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please sign the CLA. Thanks.

@alanag13
Copy link
Author

@tirkarthi I did, or at least believe I have (got an email confirmation of it being signed). Does it take a while for gh to pick that up?

@tirkarthi
Copy link
Member

It might take a couple of days from my experience and the bot will change the label automatically after that.

@serhiy-storchaka serhiy-storchaka self-requested a review February 23, 2019 05:14
@serhiy-storchaka serhiy-storchaka merged commit c7be552 into python:2.7 Feb 23, 2019
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @alanag13!

Trivial doc changes do not need signing the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alanag13 @the-knights-who-say-ni @tirkarthi @serhiy-storchaka @bedevere-bot