[2.7] bpo-37220: Fix 2.7 test -R test_IDLE failure on Windows #13958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The manual test is that |
terryjreedy
changed the title
|
Before merging, need to add 'Cherry-picked from ##### where ##### will be merge hash for #13957. |
taleinat
reviewed
Jun 11, 2019
| @@ -46,7 +46,6 @@ def test_open_and_close(self): | |||
| self.dialog.default_command = None | |||
|
|
|||
| toplevel = Toplevel(self.root) | |||
| self.addCleanup(toplevel.destroy) | |||
There was a problem hiding this comment.
I suggest the following:
def cleanup():
toplevel.update()
toplevel.destroy()
self.addCleanup(cleanup)
|
GH-114098 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 66d47da.
https://bugs.python.org/issue37220