Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39460: Disable test_zipfile.test_add_file_after_2107() #18247
+12
−0
Conversation
Disable the test because it fails on Fedora Rawhide with XFS filesystem.
This comment has been minimized.
This comment has been minimized.
|
Can we do a detection on only skip if the timestamp is weird? |
This comment has been minimized.
This comment has been minimized.
Maybe. But it seems simpler to me to skip the test until the kernel bug is fixed. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #18247 +/- ##
=========================================
Coverage 82.12% 82.12%
=========================================
Files 1955 1954 -1
Lines 588721 583389 -5332
Branches 44382 44382
=========================================
- Hits 483463 479090 -4373
+ Misses 95628 94673 -955
+ Partials 9630 9626 -4
Continue to review full report at Codecov.
|
| @@ -616,6 +616,18 @@ def test_add_file_after_2107(self): | |||
| except OverflowError: | |||
| self.skipTest('Host fs cannot set timestamp to required value.') | |||
|
|
|||
| mtime_ns = os.stat(TESTFN).st_mtime_ns | |||
| if mtime_ns != (4386268800 * 10**9): | |||
This comment has been minimized.
This comment has been minimized.
hroncok
Jan 29, 2020
Contributor
Just curious. Would you consider this better or worse than the 2 lines one?
Suggested change
| if mtime_ns != (4386268800 * 10**9): | |
| if (mtime_ns := os.stat(TESTFN).st_mtime_ns) != (4386268800 * 10**9): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 29, 2020
•
edited by bedevere-bot
Disable the test because it fails on Fedora Rawhide with XFS
filesystem.
https://bugs.python.org/issue39460