Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39153: Clarify refcounting semantics #18220
Merged
+14
−6
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks @nanjekyejoannah; I can't tell you how many times I've had to dig through the source code to remember this! |
This comment has been minimized.
This comment has been minimized.
|
@ncoghlan and @serhiy-storchaka , if this looks fine, I will merge it. |
|
@nanjekyejoannah |
Misc/NEWS.d/next/Documentation/2020-01-27-22-24-51.bpo-39153.Pjl8jV.rst
Outdated
Show resolved
Hide resolved
|
LGTM |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 29, 2020
|
Thanks @nanjekyejoannah for the PR, and @ncoghlan for merging it |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 29, 2020
|
GH-18246 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2020
Some of the *SetItem methods in the C API steal a reference to the given value. This annotates the better behaved ones to assure the reader that these are not the ones with the inconsistent behaviour. *📜 🤖 Added by blurb_it. * make docs consistent with signature Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit e1e8000) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 29, 2020
Some of the *SetItem methods in the C API steal a reference to the given value. This annotates the better behaved ones to assure the reader that these are not the ones with the inconsistent behaviour. *📜 🤖 Added by blurb_it. * make docs consistent with signature Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit e1e8000) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nanjekyejoannah commentedJan 27, 2020
•
edited by bedevere-bot
Clarify refcounting semantics for the following functions:
https://bugs.python.org/issue39153