Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #18209

Open
wants to merge 2 commits into
base: master
from
Open

fix typo #18209

wants to merge 2 commits into from

Conversation

@Bonifacio2
Copy link

Bonifacio2 commented Jan 27, 2020

Automerge-Triggered-By: @Mariatta

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 27, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Bonifacio2

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@@ -857,7 +857,7 @@ module. ``find_spec()`` returns a fully populated spec for the module.
This spec will always have "loader" set (with one exception).

To indicate to the import machinery that the spec represents a namespace
:term:`portion`. the path entry finder sets "loader" on the spec to
:term:`portion` the path entry finder sets "loader" on the spec to

This comment has been minimized.

Copy link
@cjw296

cjw296 Jan 28, 2020

Contributor

This should be a comma, not a space.

Copy link
Member

brandtbucher left a comment

Thanks for your time @Bonifacio2, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Doc/reference/import.rst Outdated Show resolved Hide resolved
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@Bonifacio2

This comment has been minimized.

Copy link
Author

Bonifacio2 commented Jan 28, 2020

Thanks for your time @Bonifacio2, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Yes, I saw it. I already created my b.p.o account, set the github account, signed the agreement, received my certificate, but https://check-python-cla.herokuapp.com/ still says I haven't signed the CLA.

@brandtbucher

This comment has been minimized.

Copy link
Member

brandtbucher commented Jan 28, 2020

Okay, I'd give it a business day or two then before it's marked as received. It's my understanding that they're processed manually by a human at the PSF.

Copy link
Member

Mariatta left a comment

Thanks!

@Bonifacio2

This comment has been minimized.

Copy link
Author

Bonifacio2 commented Jan 28, 2020

Hello, @Mariatta . Should I open the backport PRs for the 3.7 and 3.8 branches now or should I wait for this to be merged?

@brandtbucher

This comment has been minimized.

Copy link
Member

brandtbucher commented Jan 28, 2020

The bot will open them automatically. Your work here is done!

@cjw296

This comment has been minimized.

Copy link
Contributor

cjw296 commented Jan 28, 2020

@Mariatta - where can I find out what the automerge tag does? How come I appear to be able to merge this PR even though CLA is still not signed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.