Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39389: gzip: fix compression level metadata #18077
Merged
Conversation
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a gzip member header should indicate whether the DEFLATE algorithm was tuned for speed or compression ratio. Prior to this patch, archives emitted by the `gzip` module always indicated maximum compression. Test Plan: Unit tests added; they fail before this patch (in 2 of 3 cases) and pass after it. wchargin-branch: gzip-compresslevel-metadata
wchargin-branch: gzip-compresslevel-metadata
serhiy-storchaka
merged commit eab3b3f
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 21, 2020
|
Thanks @wchargin for the PR, and @serhiy-storchaka for merging it |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2020
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a gzip member header should indicate whether the DEFLATE algorithm was tuned for speed or compression ratio. Prior to this patch, archives emitted by the `gzip` module always indicated maximum compression. (cherry picked from commit eab3b3f) Co-authored-by: William Chargin <wchargin@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 21, 2020
|
GH-18100 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2020
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a gzip member header should indicate whether the DEFLATE algorithm was tuned for speed or compression ratio. Prior to this patch, archives emitted by the `gzip` module always indicated maximum compression. (cherry picked from commit eab3b3f) Co-authored-by: William Chargin <wchargin@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 21, 2020
|
GH-18101 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 21, 2020
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a gzip member header should indicate whether the DEFLATE algorithm was tuned for speed or compression ratio. Prior to this patch, archives emitted by the `gzip` module always indicated maximum compression. (cherry picked from commit eab3b3f) Co-authored-by: William Chargin <wchargin@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
@serhiy-storchaka: Great; thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wchargin commentedJan 20, 2020
•
edited by bedevere-bot
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a
gzip member header should indicate whether the DEFLATE algorithm was
tuned for speed or compression ratio. Prior to this patch, archives
emitted by the
gzipmodule always indicated maximum compression.Test Plan:
Unit tests added; they fail before this patch (in 2 of 3 cases) and pass
after it.
wchargin-branch: gzip-compresslevel-metadata
https://bugs.python.org/issue39389