Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30780: Add IDLE configdialog tests #3592

Merged
merged 11 commits into from Jan 27, 2020
Merged

bpo-30780: Add IDLE configdialog tests #3592

merged 11 commits into from Jan 27, 2020
+149 −31

Conversation

@csabella
Copy link
Contributor

csabella commented Sep 14, 2017 •
edited by terryjreedy

Expose dialog buttons to test code. Complete coverage for highlight and keys tabs
and for buttons and their functions.

https://bugs.python.org/issue30780
@terryjreedy terryjreedy self-assigned this May 20, 2018
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches
csabella added 2 commits Sep 14, 2017
@csabella
bpo-30780: IDLE: Complete keys and highlight coverage for configdialo…
ef4584c 
…g and add tests for buttons.
@csabella
Correct tests due to other changes
Loading status checks…
648b850
@csabella csabella force-pushed the csabella:bpo30780 branch from 5f47a68 to 648b850 Jan 19, 2020
@csabella csabella requested a review from terryjreedy as a code owner Jan 19, 2020
@csabella csabella mentioned this pull request Jan 25, 2020
Merged
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 25, 2020 •
edited

I fixed the overt conflicts with the web editor. I fixed the failure on my local branch. I forgot that patch can only be used to temporarily replace existing attribute, not temporarily add new attribute. I intend to add context manager to idle_test.mock_idle for the latter, so we don't have to explicitly delete when instance is persistent across tests, as dialog is. I am now reviewing other tests and will add blurb and NEWS.txt items and update coverage when ready to commit.
@terryjreedy
Merge branch 'master' into bpo30780
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcea0fb
@terryjreedy terryjreedy changed the title bpo-30780: IDLE: Complete keys and highlight coverage for configdialo… bpo-30780: Add IDLE configdialog tests Jan 25, 2020
terryjreedy added 5 commits Jan 25, 2020
@terryjreedy
Fix test failure - cannot use patch for instance addition and deletion.
45e60ff
@terryjreedy
Use mock.patch.object as context manager.
Loading status checks…
5a8e94f
@terryjreedy
Test selection block bindings.
14e9efc
@terryjreedy
Eliminate reason to test with duplicate new names.
0b234eb
@terryjreedy
Complete last commit, which changed highlight code
Loading status checks…
168d07e 
and deleted unneeded keys test code.  This does opposite.
@terryjreedy
terryjreedy reviewed Jan 26, 2020
View changes
Copy link
Member

terryjreedy left a comment

I still need to look at the new test_delete_custom_theme/keys code.
Lib/idlelib/configdialog.py Outdated Show resolved Hide resolved
Lib/idlelib/idle_test/test_configdialog.py Outdated Show resolved Hide resolved
Lib/idlelib/idle_test/test_configdialog.py Show resolved Hide resolved
Lib/idlelib/idle_test/test_configdialog.py Outdated Show resolved Hide resolved
Lib/idlelib/idle_test/test_configdialog.py Outdated Show resolved Hide resolved
terryjreedy added 3 commits Jan 27, 2020
@terryjreedy
News items.
Loading status checks…
18499bf
@terryjreedy
Update NEWS.txt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60982c4
@terryjreedy
Update 2020-01-27-16-44-29.bpo-30780.nR80qu.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c7d7ce2
@terryjreedy
terryjreedy approved these changes Jan 27, 2020
View changes
Copy link
Member

terryjreedy left a comment

Will merge when CI passes again.
Lib/idlelib/idle_test/test_configdialog.py
theme_name2 = 'other theme'
idleConf.userCfg['highlight'].SetOption(theme_name2, 'name', 'value')
highpage[theme_name2] = {'option': 'False'}

This comment has been minimized.

Sign in to view
Copy link
@terryjreedy

terryjreedy Jan 27, 2020

Member

This and the corresponding additions for keys cover the failure of if not item_list and the else clause. I suspect it could be done in fewer lines, but I hope to someday factor out the common code, simpfiy the UI, and redo the tests anyway. So leave the additions alone.
@terryjreedy terryjreedy merged commit dd023ad into python:master Jan 27, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200127.51 succeeded
Details
bedevere/issue-number Issue number 30780 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 27, 2020

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@csabella @miss-islington
bpo-30780: Add IDLE configdialog tests (pythonGH-3592)
fb97d52 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 27, 2020

GH-18218 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 27, 2020

GH-18219 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 27, 2020
@csabella @miss-islington
bpo-30780: Add IDLE configdialog tests (pythonGH-3592)
7a93e89 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @csabella
bpo-30780: Add IDLE configdialog tests (GH-3592)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5aefee6 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2020
@miss-islington @csabella
bpo-30780: Add IDLE configdialog tests (GH-3592)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7b57b15 
Expose dialog buttons to test code and complete their test coverage.
Complete test coverage for highlights and keys tabs.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit dd023ad)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the csabella:bpo30780 branch Jan 28, 2020
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

csabella commented Jan 28, 2020

Terry, thanks for merging this! 🙂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
CLA signed type-tests
Projects
None yet
Milestone
No milestone
6 participants
@csabella @vstinner @terryjreedy @bedevere-bot @miss-islington @the-knights-who-say-ni
You can’t perform that action at this time.