Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-15243: Specify __prepare__ should be a classmethod #17124

Merged
merged 1 commit into from Jan 25, 2020
Merged

bpo-15243: Specify __prepare__ should be a classmethod #17124

merged 1 commit into from Jan 25, 2020

Conversation

@alclarks
Copy link
Contributor

alclarks commented Nov 12, 2019 •
edited by bedevere-bot

Hi,

This is an updated patch for the issue https://bugs.python.org/issue15243 - specifying that prepare should be a classmethod.

@brandtbucher

https://bugs.python.org/issue15243
@alclarks
Specify __prepare__ should be a classmethod
Loading status checks…
6a8cc15
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Nov 12, 2019

Thanks for your time @alclarks, and welcome to CPython! 😎
@brandtbucher
brandtbucher approved these changes Nov 12, 2019
View changes
Copy link
Member

brandtbucher left a comment

This one actually bit me a couple of weeks ago. Looks good!
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Nov 12, 2019

@berkerpeksag
@alclarks

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

alclarks commented Nov 20, 2019

Hi @berkerpeksag, if this change looks good can it please be merged?
@csabella csabella requested a review from berkerpeksag Jan 25, 2020
@berkerpeksag
berkerpeksag approved these changes Jan 25, 2020
View changes
Copy link
Member

berkerpeksag left a comment

LGTM, thanks! The example I mentioned in the issue seems to be removed without a replacement in c2ccac7.
@berkerpeksag berkerpeksag merged commit 7de6174 into python:master Jan 25, 2020
4 checks passed
4 checks passed
Azure Pipelines PR #20191112.26 succeeded
Details
bedevere/issue-number Issue number 15243 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 25, 2020

Thanks @alclarks for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

GH-18185 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 25, 2020

GH-18186 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@alclarks @miss-islington
bpo-15243: Document __prepare__ as classmethod (pythonGH-17124)
4f3a77e 
(cherry picked from commit 7de6174)

Co-authored-by: alclarks <57201106+alclarks@users.noreply.github.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@alclarks @miss-islington
bpo-15243: Document __prepare__ as classmethod (pythonGH-17124)
3e2e099 
(cherry picked from commit 7de6174)

Co-authored-by: alclarks <57201106+alclarks@users.noreply.github.com>
berkerpeksag added a commit that referenced this pull request Jan 25, 2020
@miss-islington @alclarks @berkerpeksag
bpo-15243: Document __prepare__ as classmethod (GH-17124)
Loading status checks…
321491a 
(cherry picked from commit 7de6174)

Co-authored-by: alclarks <57201106+alclarks@users.noreply.github.com>
berkerpeksag added a commit that referenced this pull request Jan 25, 2020
@miss-islington @alclarks @berkerpeksag
bpo-15243: Document __prepare__ as classmethod (GH-17124)
Loading status checks…
548685e 
(cherry picked from commit 7de6174)

Co-authored-by: alclarks <57201106+alclarks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@alclarks @brandtbucher @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni
You can’t perform that action at this time.