New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32173: linecache.py add lazycache to all and use dict.clear to clear the cache #4641

Merged

csabella merged 1 commit into python:master from ganziqim:master

Jan 26, 2020

Contributor

ganziqim commented Nov 30, 2017 •

edited by bedevere-bot

https://bugs.python.org/issue32173

the-knights-who-say-ni commented Nov 30, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

the-knights-who-say-ni added the CLA not signed label

bedevere-bot added the awaiting review label

lisroach approved these changes

Contributor

lisroach left a comment

I think this is a reasonable diff, lazycache should be added to all and the clearcache is improved by using clear().

The extra code changes are just semantics which help code readability without changing any functionality.

bedevere-bot added awaiting core review and removed awaiting review labels

Contributor Author

ganziqim commented Dec 3, 2017

I've been signed for three times, but the state has not changed

asvetlov removed the CLA not signed label

the-knights-who-say-ni added the CLA signed label

Contributor

asvetlov commented Dec 3, 2017

CLA status updated

ganziqim force-pushed the ganziqim:master branch from 1e19632 to ee8a2b9

Contributor Author

ganziqim commented Dec 4, 2017

news entry added

asvetlov approved these changes

bedevere-bot added awaiting merge and removed awaiting core review labels

asvetlov self-assigned this

Mariatta requested changes

Misc/NEWS.d/next/Library/2017-12-04-10-14-23.bpo-32173.e0C5dF.rst Outdated Show resolved Hide resolved

bedevere-bot commented Jan 6, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added awaiting changes and removed awaiting merge labels

srinivasreddy mentioned this pull request

bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #10130

Open

Contributor

csabella commented Mar 17, 2019

This issue is approved by 2 core developers, but was waiting on an update to the blurb.

@ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks!

ganziqim force-pushed the ganziqim:master branch 2 times, most recently from d097431 to 4b004f7


        Fix linecache.py add lazycache to __all__ and use dict.clear to clear…

a15377c

… the cache

ganziqim force-pushed the ganziqim:master branch from 4b004f7 to a15377c

Contributor Author

ganziqim commented Mar 18, 2019

This issue is approved by 2 core developers, but was waiting on an update to the blurb.

@ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks!

done.

Contributor

csabella commented Mar 18, 2019

@ganziqim Thanks!

@lisroach @asvetlov I believe Mariatta is out of open source starting today, so, if you can, please review the changes made to the news entry. Thank you!

csabella merged commit 4515a59 into python:master

5 checks passed

5 checks passed

Azure Pipelines PR #20190318.15 succeeded

Details

bedevere/issue-number Issue number 32173 found

Details

bedevere/news News entry found in Misc/NEWS.d

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

bedevere-bot removed the awaiting changes label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.