bpo-36620 [First-time contributor] Update itertools.rst add optional args to function definitions. #13210
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
@lisroach pls review thanks :) |
| @@ -0,0 +1 @@ | |||
| Update itertools documentation with optional args registration. | |||
There was a problem hiding this comment.
Can you actually remove the NEWS entry? For small documentation fixes an NEWS entry isn't really needed, and can end up cluttering up the news at the end of the day.
There was a problem hiding this comment.
@lisroach should be removed! I thought it was required because the CI checks had a large red X on not having a NEWS entry filled out, then the category disappeared after I filled it out (not sure if it's because I filled it out and it completed or if the CI checks deleted the category after PR instantiation).
There was a problem hiding this comment.
Okay I get it now; the .rst file must be present but the entry is "skip news" for the bot to skip news. Updated.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…om VS2008 to VS2010." This commit is a partial backport of python/cpython@401f9f3. It was originally designed to work with python-cmake-buildsystem. The following modules have NOT been backported: * Tools/msi * Tools/buildbot * PCBuild
https://bugs.python.org/issue36620