Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPy_DECREF: only pass filename if Py_REF_DEBUG is defined #17870
Merged
+10
−5
Conversation
This comment has been minimized.
This comment has been minimized.
|
See PR #16781 for my first attempt. |
This comment has been minimized.
This comment has been minimized.
|
@Yhg1s @serhiy-storchaka: Does this version look better than PR #16781? |
This comment has been minimized.
This comment has been minimized.
|
cc @pablogsal |
|
Yes, this looks better to me. The ifdef dance isn't too bad, and it's no longer duplicating logic. |
Include/object.h
Outdated
| #ifdef Py_REF_DEBUG | ||
| const char *filename, int lineno, | ||
| #endif | ||
| PyObject *op) | ||
| { | ||
| (void)filename; /* may be unused, shut up -Wunused-parameter */ |
This comment has been minimized.
This comment has been minimized.
Yhg1s
Jan 8, 2020
Member
These suppressions shouldn't be necessary anymore, but if they are, they should be conditional.
This comment has been minimized.
This comment has been minimized.
vstinner
Jan 8, 2020
Author
Member
The suppression are needed with the current code, since filename & fileno are not used for a release build. It's the purpose of my change: don't pass them if we don't need them ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 6, 2020
Filename and line numbers are not needed when Py_REF_DEBUG are not
defined.
The static inline _Py_DECREF() function was introduced by
commit 2aaf0c1.