bpo-30462: urllib: NO_PROXY env. variable can contain domain with asterisk #1795
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@jirihnidek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @orsenthil, @birkenfeld and @ronaldoussoren to be potential reviewers. |
|
I signed CLA before I created this PR. |
|
I don't see how this PR is related to bpo-12345. |
jirihnidek
changed the title
|
@serhiy-storchaka sorry, I copy pasted the the name of issue from template :-(. I update the name and of course the right link to issue: http://bugs.python.org/issue30462 was already there. |
* Bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=1443164 * Method proxy_bypass_environment() from urllib does not support no_proxy with items containing asterisk (e.g.: *.redhat.com). Thus values in this environment variable is preprocessed and leading asterisks are stripped. * There was opened PR for urllib to address this problem in proper way: python/cpython#1795 * Fixed functional tests for python-rshm * Added two more functional tests. * Added several functional unit tests for no_proxy environment value containing asterisk. * Small tweaks of code style (too long lines).
* Bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=1443164 * Method proxy_bypass_environment() from urllib does not support no_proxy with items containing asterisk (e.g.: *.redhat.com). Thus values in this environment variable is preprocessed and leading asterisks are stripped. * There was opened PR for urllib to address this problem in proper way: python/cpython#1795 * Fixed functional tests for python-rshm * Added two more functional tests. * Added several functional unit tests for no_proxy environment value containing asterisk. * Refactored local variables to remove possible interference with module rhsm.connection. * Small tweaks of code style (too long lines).
* Bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=1443164 * Method proxy_bypass_environment() from urllib does not support no_proxy with items containing asterisk (e.g.: *.redhat.com). Thus values in this environment variable is preprocessed and leading asterisks are stripped. * There was opened PR for urllib to address this problem in proper way: python/cpython#1795 * Fixed functional tests for python-rshm * Added two more functional tests. * Added several functional unit tests for no_proxy environment value containing asterisk. * Refactored local variables to remove possible interference with module rhsm.connection. * Try to clear following environment variables before each unit test is performed in ConnectionTests test case: - no_proxy - NO_PROXY - HTTPS_PROXY * Small tweaks of code style (too long lines).
|
@jirihnidek can you add your GitHub username to your account in bugs.python.org? Thanks. |
|
@Mariatta I just added my username to bugs.python.org. |
…erisk * The method proxy_bypass_environment() is possible to bypass host, when NO_PROXY or no_proxy variable include domain specified with asterisk at the begining. e.g.: *.python.org. * Added and extended unit tests to conver new functionality.
jirihnidek
force-pushed
the
fix-issue-30462
branch
from
22e6d16 to
8337ef7
Compare
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@jirihnidek, please make the changes requested by @zhangyangyu in the code review. Thanks! |
|
@csabella I will do. :-) |
|
@jirihnidek, please address the comments and resolve the merge conflicts. If it's something you're not interested in anymore, feel free to close the PR. Thanks! |
|
I'm going to close this PR as inactive. If the original author is interested in pursuing this, then this can be reopened or someone else can create a new PR to replace it. If a new PR is created, please give credit to the original author. Thanks! |
host, when NO_PROXY or no_proxy variable include domain
specified with asterisk at the begining. e.g.: *.python.org.