Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39497: Remove unused variable from pysqlite_cursor_executescript #18271

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39497: Remove unused variable from pysqlite_cursor_executescript #18271

wants to merge 1 commit into from
+0 −3

Conversation

@alexhenrie
Copy link
Contributor

alexhenrie commented Jan 30, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39497
@alexhenrie
bpo-39497: Remove unused variable from pysqlite_cursor_executescript
Loading status checks…
5b4032b
@alexhenrie alexhenrie requested a review from berkerpeksag as a code owner Jan 30, 2020
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #18271 into master will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18271       +/-   ##
===========================================
- Coverage   83.24%   82.12%    -1.13%     
===========================================
  Files        1570     1954      +384     
  Lines      414213   583371   +169158     
  Branches    44401    44401               
===========================================
+ Hits       344823   479090   +134267     
- Misses      59746    94641    +34895     
+ Partials     9644     9640        -4
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188bb5b...5b4032b. Read the comment docs.
@corona10 corona10 added the skip news label Jan 30, 2020
@corona10
corona10 approved these changes Jan 30, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
CLA signed awaiting core review skip news
Projects
None yet
Milestone
No milestone
4 participants
@alexhenrie @corona10 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.