bpo-38792: Remove IDLE shell calltip before new prompt. #17150

ZackerySpytz · 2019-11-14T06:53:17Z

Previously, a calltip might be left after SyntaxError, KeyboardInterrupt, or Shell Restart..

https://bugs.python.org/issue38792


        bpo-38792: IDLE calltips may not properly close on KeyboardInterrupt

Calltips should be removed if a KeyboardInterrupt occurs.

taleinat · 2019-11-14T10:11:50Z

Hi Zack, thanks for this!

This doesn't go far enough, actually; we should make sure to close the calltip in other cases too, such as restarting the shell or hitting return to running a statement / block. It is a bit hairy to see where the best place to add this is.

Let me know if you're interested in doing more work on this and testing various edge cases.


        Merge remote-tracking branch 'origin/master' into pr_17150


        Code changes.


        News items.

terryjreedy

I tested interrupts and restarts before, during, and after calltips. Before and after had no new problems and during now works properly. I also tested some in editor. Zack, thanks for report and initial fix. I plan to merge tomorrow.

@taleinat If you find a way to execute with Enter and have calltip persist, we can try to fix in another PR, making sure to not regress in editor.

taleinat · 2020-01-30T11:06:49Z

Even with this fix, it is still easy and common to get a calltip staying open in other ways. For example, hitting Enter in the shell with a calltip open and a syntax error, as in the following image:

Removing any open call-tips in PyShell.resetoutput() could be a more comprehensive solution to these issues. I'm testing it locally now.


        move hiding the calltip into PyShell.resetoutput()


        slightly reword NEWS entry

taleinat · 2020-01-30T13:50:25Z

Removing any open call-tips in PyShell.resetoutput() could be a more comprehensive solution to these issues. I'm testing it locally now.

This looks to be working very nicely. I've pushed this change into this PR, I hope you like it!

terryjreedy · 2020-01-31T01:54:29Z

I got the same with int(',. This should be seen as hitting return to continue on a new line, not to run. But the syntax error causes a new prompt. It is plausible that the calltip should disappear, though if one follows with Alt-P <>, then one might want it.

I like handling this in one place. Among other reasons, Zack originally used refresh calltip event rather than remove calltip window. I switched because I don't believe the extra code in the former is needed. (refresh_calltip_event is only triggered by and not by other actions that close a calltip.) But if I am wrong, the fix would only be needed one place.

miss-islington · 2020-01-31T01:55:45Z

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2020-01-31T01:55:45Z

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!


        bpo-38792: Remove IDLE shell calltip before new prompt. (pythonGH-17150)

Previously, a calltip might be left after SyntaxError, KeyboardInterrupt, or Shell Restart. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tal Einat <taleinat+github@gmail.com> (cherry picked from commit bfdeaa3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

bedevere-bot · 2020-01-31T01:55:57Z

GH-18287 is a backport of this pull request to the 3.8 branch.


        bpo-38792: Remove IDLE shell calltip before new prompt. (pythonGH-17150)

Previously, a calltip might be left after SyntaxError, KeyboardInterrupt, or Shell Restart. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tal Einat <taleinat+github@gmail.com> (cherry picked from commit bfdeaa3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

bedevere-bot · 2020-01-31T01:56:04Z

GH-18288 is a backport of this pull request to the 3.7 branch.


        bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150)

Previously, a calltip might be left after SyntaxError, KeyboardInterrupt, or Shell Restart. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tal Einat <taleinat+github@gmail.com> (cherry picked from commit bfdeaa3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>


        bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150)

Previously, a calltip might be left after SyntaxError, KeyboardInterrupt, or Shell Restart. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Tal Einat <taleinat+github@gmail.com> (cherry picked from commit bfdeaa3) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

bpo-38792: IDLE calltips may not properly close on KeyboardInterrupt

Loading status checks…

6d18880

Calltips should be removed if a KeyboardInterrupt occurs.

ZackerySpytz requested a review from terryjreedy as a code owner Nov 14, 2019

the-knights-who-say-ni added the CLA signed label Nov 14, 2019

bedevere-bot added the awaiting review label Nov 14, 2019

terryjreedy added 3 commits Jan 30, 2020

Merge remote-tracking branch 'origin/master' into pr_17150

79f4541

Code changes.

c2f61c3

News items.

Loading status checks…

8fed41a

terryjreedy approved these changes Jan 30, 2020

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Jan 30, 2020

taleinat added 2 commits Jan 30, 2020

move hiding the calltip into PyShell.resetoutput()

Verified

This commit was signed with a verified signature.

taleinat Tal Einat

GPG key ID: 613A98AF4C800CDA Learn about signing commits

8e3868b

slightly reword NEWS entry

Verified

This commit was signed with a verified signature.

taleinat Tal Einat

GPG key ID: 613A98AF4C800CDA Learn about signing commits

Loading status checks…

6d81dbe

terryjreedy changed the title ~~bpo-38792: IDLE calltips may not properly close on KeyboardInterrupt~~ bpo-38792: Remove IDLE shell calltip before new prompt. Jan 31, 2020

terryjreedy added needs backport to 3.7 needs backport to 3.8 type-bugfix labels Jan 31, 2020

bedevere-bot removed the awaiting merge label Jan 31, 2020

bedevere-bot removed the needs backport to 3.8 label Jan 31, 2020

bedevere-bot removed the needs backport to 3.7 label Jan 31, 2020

python / cpython

bpo-38792: Remove IDLE shell calltip before new prompt. #17150

bpo-38792: Remove IDLE shell calltip before new prompt. #17150

ZackerySpytz commented Nov 14, 2019 •

edited by terryjreedy

This comment has been minimized.

taleinat commented Nov 14, 2019 •

edited

terryjreedy left a comment

This comment has been minimized.

taleinat commented Jan 30, 2020

This comment has been minimized.

taleinat commented Jan 30, 2020 •

edited

This comment has been minimized.

terryjreedy commented Jan 31, 2020

This comment has been minimized.

miss-islington commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

python / cpython

Sponsor python/cpython

Join GitHub today

bpo-38792: Remove IDLE shell calltip before new prompt. #17150

bpo-38792: Remove IDLE shell calltip before new prompt. #17150

Conversation

ZackerySpytz commented Nov 14, 2019 • edited by terryjreedy

This comment has been minimized.

taleinat commented Nov 14, 2019 • edited

terryjreedy left a comment

This comment has been minimized.

taleinat commented Jan 30, 2020

This comment has been minimized.

taleinat commented Jan 30, 2020 • edited

This comment has been minimized.

terryjreedy commented Jan 31, 2020

This comment has been minimized.

miss-islington commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

This comment has been minimized.

bedevere-bot commented Jan 31, 2020

ZackerySpytz commented Nov 14, 2019 •

edited by terryjreedy

taleinat commented Nov 14, 2019 •

edited

taleinat commented Jan 30, 2020 •

edited