Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39489: Remove COUNT_ALLOCS special build #18259

Open
wants to merge 2 commits into
base: master
from
Open

bpo-39489: Remove COUNT_ALLOCS special build #18259

wants to merge 2 commits into from
+24 −470

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 29, 2020 •
edited by bedevere-bot

Remove:

  • COUNT_ALLOCS macro
  • sys.getcounts() function
  • SHOW_ALLOC_COUNT code in listobject.c
  • SHOW_TRACK_COUNT code in tupleobject.c
  • PyConfig.show_alloc_count field
  • -X showalloccount command line option
  • @test.support.requires_type_collecting decorator

https://bugs.python.org/issue39489
@vstinner vstinner requested review from gpshead and vsajip as code owners Jan 29, 2020
@vstinner
bpo-39489: Remove COUNT_ALLOCS special build
Loading status checks…
a8409ab 
Remove:

* COUNT_ALLOCS macro
* sys.getcounts() function
* SHOW_ALLOC_COUNT code in listobject.c
* SHOW_TRACK_COUNT code in tupleobject.c
* PyConfig.show_alloc_count field
* -X showalloccount command line option
* @test.support.requires_type_collecting decorator
@vstinner vstinner force-pushed the vstinner:remove_count_allocs branch from 2da0717 to a8409ab Jan 29, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 29, 2020

PR rebased to fix a conflict in object.c. I also removed hasattr(sys, 'getcounts') in test_sys.
@vstinner
_Py_ForgetReference() uses Py_UNUSED() macro
Loading status checks…
fc4ee6e
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 29, 2020

This PR does mostly remove code, statistics:

34 files changed, 24 insertions(+), 470 deletions(-)
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #18259 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18259     +/-   ##
=========================================
  Coverage   82.12%   82.12%             
=========================================
  Files        1955     1954      -1     
  Lines      588705   583348   -5357     
  Branches    44401    44400      -1     
=========================================
- Hits       483459   479070   -4389     
+ Misses      95600    94639    -961     
+ Partials     9646     9639      -7
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 322 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5428f48...fc4ee6e. Read the comment docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

@vsajip vsajip

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.